Skip to content
Permalink
Browse files

util: don't set the prototype of callbackified functions

Using `util.callbackify()` should not set the prototype for the
returned function to the one from the input function. It could cause
confusion while debugging otherwise.

PR-URL: #26893
Fixes: #26890
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information...
BridgeAR committed Mar 24, 2019
1 parent 46bf0d0 commit b5ea925c8e30aa85f1821f3bd9833b52608bf91e
Showing with 5 additions and 1 deletion.
  1. +0 −1 lib/util.js
  2. +5 −0 test/parallel/test-util-callbackify.js
@@ -194,7 +194,6 @@ function callbackify(original) {
(rej) => process.nextTick(callbackifyOnRejected, rej, cb));
}

Object.setPrototypeOf(callbackified, Object.getPrototypeOf(original));
const descriptors = Object.getOwnPropertyDescriptors(original);
// It is possible to manipulate a functions `length` or `name` property. This
// guards against the manipulation.
@@ -157,6 +157,11 @@ const values = [

const cbAsyncFn = callbackify(asyncFn);
assert.strictEqual(cbAsyncFn.length, 2);
assert.notStrictEqual(
Object.getPrototypeOf(cbAsyncFn),
Object.getPrototypeOf(asyncFn)
);
assert.strictEqual(Object.getPrototypeOf(cbAsyncFn), Function.prototype);
cbAsyncFn(value, common.mustCall((err, ret) => {
assert.ifError(err);
assert.strictEqual(ret, value);

0 comments on commit b5ea925

Please sign in to comment.
You can’t perform that action at this time.