Skip to content
Browse files

test: check that benchmark tests are minimal

Check that benchmark tests are not running longer than necessary by
confirming that they only produce one set of configs to report on per
benchmark file.

PR-URL: #21046
Reviewed-By: Anatoli Papirovski <>
Reviewed-By: James M Snell <>
Reviewed-By: Anna Henningsen <>
  • Loading branch information
Trott committed Jun 19, 2018
1 parent d10742d commit b72de3d5083ebee39a9870b40a1a473cf9cc744e
Showing with 18 additions and 1 deletion.
  1. +18 −1 test/common/benchmark.js
@@ -20,10 +20,27 @@ function runBenchmark(name, args, env) {

const mergedEnv = Object.assign({}, process.env, env);

const child = fork(runjs, argv, { env: mergedEnv });
const child = fork(runjs, argv, { env: mergedEnv, stdio: 'pipe' });

let stdout = '';
child.stdout.on('data', (line) => {
stdout += line;

child.on('exit', (code, signal) => {
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
// This bit makes sure that each benchmark file is being sent settings such
// that the benchmark file runs just one set of options. This helps keep the
// benchmark tests from taking a long time to run. Therefore, each benchmark
// file should result in three lines of output: a blank line, a line with
// the name of the benchmark file, and a line with the only results that we
// get from testing the benchmark file.
`benchmark file not running exactly one configuration in test: ${stdout}`

0 comments on commit b72de3d

Please sign in to comment.
You can’t perform that action at this time.