Skip to content
Permalink
Browse files

test: fix test-repl-envvars

In 180f865, the test was changed
so that the `env` argument of `createInternalRepl()` also contained
external environment variables, because keeping them can be necessary
for spawning processes on some systems.

However, this test does not spawn new processes, and relies on the
fact that the environment variables it tests are not already set
(and fails otherwise); therefore, reverting to the original state
should fix this.

Fixes: #21451
Fixes: nodejs/build#1377
Refs: #25219

PR-URL: #25226
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
addaleax committed Dec 26, 2018
1 parent 438f76b commit b7b1d7eb8842a18f187eedbba5b4ff2d30999df6
Showing with 1 addition and 1 deletion.
  1. +1 −1 test/parallel/test-repl-envvars.js
@@ -36,7 +36,7 @@ const tests = [
];

function run(test) {
const env = Object.assign({}, process.env, test.env);
const env = test.env;
const expected = test.expected;
const opts = {
terminal: true,

0 comments on commit b7b1d7e

Please sign in to comment.
You can’t perform that action at this time.