Skip to content
Permalink
Browse files

benchmark: support optional headers with wrk

wrk did not support sending optional headers, they were silently
ignored. This appears to be an oversight, they were supported for
autocannon.

PR-URL: nodejs-private/node-private#189
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
sam-github authored and BethGriggs committed Jan 14, 2020
1 parent 340a1bd commit b7da194714d27b3eda49c32cd58019949eadbc1f
Showing with 3 additions and 0 deletions.
  1. +3 −0 benchmark/_http-benchmarkers.js
@@ -64,6 +64,9 @@ class WrkBenchmarker {
'-t', 8,
`http://127.0.0.1:${options.port}${options.path}`,
];
for (const field in options.headers) {
args.push('-H', `${field}: ${options.headers[field]}`);
}
const child = child_process.spawn(this.executable, args);
return child;
}

0 comments on commit b7da194

Please sign in to comment.
You can’t perform that action at this time.