Skip to content

Commit

Permalink
benchmark: support optional headers with wrk
Browse files Browse the repository at this point in the history
wrk did not support sending optional headers, they were silently
ignored. This appears to be an oversight, they were supported for
autocannon.

PR-URL: nodejs-private/node-private#189
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
sam-github authored and BethGriggs committed Feb 1, 2020
1 parent 340a1bd commit b7da194
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions benchmark/_http-benchmarkers.js
Expand Up @@ -64,6 +64,9 @@ class WrkBenchmarker {
'-t', 8, '-t', 8,
`http://127.0.0.1:${options.port}${options.path}`, `http://127.0.0.1:${options.port}${options.path}`,
]; ];
for (const field in options.headers) {
args.push('-H', `${field}: ${options.headers[field]}`);
}
const child = child_process.spawn(this.executable, args); const child = child_process.spawn(this.executable, args);
return child; return child;
} }
Expand Down

0 comments on commit b7da194

Please sign in to comment.