Permalink
Browse files

test: refactor test-http-client-timeout-option-with-agent

* Switch from Date.now() to process.hrtime.bigint().
* Move start time recording to before the request is created, not after.

Fixes: #25746

PR-URL: #25752
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Trott committed Jan 28, 2019
1 parent 8e6667f commit b8977045f209c0de2d4d0333d098acd1823ded63
Showing with 3 additions and 3 deletions.
  1. +3 −3 test/parallel/test-http-client-timeout-option-with-agent.js
@@ -30,8 +30,8 @@ server.listen(0, options.host, () => {

function doRequest() {
options.port = server.address().port;
const start = process.hrtime.bigint();
const req = http.request(options);
const start = Date.now();
req.on('error', () => {
// This space is intentionally left blank.
});
@@ -40,11 +40,11 @@ function doRequest() {
let timeout_events = 0;
req.on('timeout', common.mustCall(() => {
timeout_events += 1;
const duration = Date.now() - start;
const duration = process.hrtime.bigint() - start;
// The timeout event cannot be precisely timed. It will delay
// some number of milliseconds.
assert.ok(
duration >= HTTP_CLIENT_TIMEOUT,
duration >= BigInt(HTTP_CLIENT_TIMEOUT * 1e6),
`duration ${duration}ms less than timeout ${HTTP_CLIENT_TIMEOUT}ms`
);
}));

0 comments on commit b897704

Please sign in to comment.