Permalink
Browse files

test: fix ::1 error in test-dns-ipv6

If ::1 can't be resolved, the test should still pass.

PR-URL: #8254
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information...
gibfahn authored and Fishrock123 committed Aug 26, 2016
1 parent 76a3050 commit b8fa7c949d62dbb7d1e7e9d5b4ff3ae1cedd0c81
Showing with 6 additions and 1 deletion.
  1. +6 −1 test/internet/test-dns-ipv6.js
@@ -179,7 +179,12 @@ TEST(function test_lookup_all_ipv6(done) {
TEST(function test_lookupservice_ip_ipv6(done) {
var req = dns.lookupService('::1', 80, function(err, host, service) {
if (err) throw err;
if (err) {
// Not skipping the test, rather checking an alternative result,
// i.e. that ::1 may not be configured (e.g. in /etc/hosts)
assert.strictEqual(err.code, 'ENOTFOUND');
return done();
}
assert.equal(typeof host, 'string');
assert(host);
assert(['http', 'www', '80'].includes(service));

0 comments on commit b8fa7c9

Please sign in to comment.