From b9bd4e9d0958e2d28289e3d6e8ec1689a9092aa6 Mon Sep 17 00:00:00 2001 From: Gary Hsu Date: Wed, 21 Nov 2018 10:53:22 -0800 Subject: [PATCH] src: add include for standalone compile - Include algorithm header in js_native_api_v8.cc since std::min requires it. - Add comments to js_native_api_v8_internals.h for NAPI_VERSION PR-URL: https://github.com/nodejs/node/pull/24498 Reviewed-By: Refael Ackermann Reviewed-By: James M Snell Reviewed-By: Gabriel Schulhof Reviewed-By: Colin Ihrig Reviewed-By: Joyee Cheung --- src/js_native_api_v8.cc | 1 + src/js_native_api_v8_internals.h | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/js_native_api_v8.cc b/src/js_native_api_v8.cc index b28376afb7cedd..144cfad8e438b2 100644 --- a/src/js_native_api_v8.cc +++ b/src/js_native_api_v8.cc @@ -1,5 +1,6 @@ #include // INT_MAX #include +#include #define NAPI_EXPERIMENTAL #include "js_native_api_v8.h" #include "js_native_api.h" diff --git a/src/js_native_api_v8_internals.h b/src/js_native_api_v8_internals.h index 91baae6a3b8201..dcdc62297f6f59 100644 --- a/src/js_native_api_v8_internals.h +++ b/src/js_native_api_v8_internals.h @@ -4,11 +4,14 @@ // The V8 implementation of N-API, including `js_native_api_v8.h` uses certain // idioms which require definition here. For example, it uses a variant of // persistent references which need not be reset in the constructor. It is the -// responsibility of this file to define these idioms. +// responsibility of this file to define these idioms. Optionally, this file +// may also define `NAPI_VERSION` and set it to the version of N-API to be +// exposed. // In the case of the Node.js implementation of N-API some of the idioms are // imported directly from Node.js by including `node_internals.h` below. Others -// are bridged to remove references to the `node` namespace. +// are bridged to remove references to the `node` namespace. `node_version.h`, +// included below, defines `NAPI_VERSION`. #include "node_version.h" #include "env.h"