Skip to content
Permalink
Browse files

http2: fix memory leak for uncommon headers

Fix a memory leak that occurs with header names that are
short and not present in the static table of default headers.

PR-URL: #21336
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
  • Loading branch information...
addaleax authored and targos committed Jun 15, 2018
1 parent 17c21b6 commit bcaf59c73948fe9a4c46e26990e5fb25a95cc36c
Showing with 1 addition and 0 deletions.
  1. +1 −0 src/node_http2.h
@@ -1203,6 +1203,7 @@ class ExternalHeader :
}

if (may_internalize && vec.len < 64) {
nghttp2_rcbuf_decref(buf);
// This is a short header name, so there is a good chance V8 already has
// it internalized.
return GetInternalizedString(env, vec);

0 comments on commit bcaf59c

Please sign in to comment.
You can’t perform that action at this time.