Browse files

src: remove TODO about uv errno removal

This commit removes a TODO regarding the removal of uv errno. errno
is currently used and cannot be removed so removing the comment to
avoid any confusion.

PR-URL: #12536
Ref: #4641
Reviewed-By: Colin Ihrig <>
Reviewed-By: Anna Henningsen <>
Reviewed-By: James M Snell <>
  • Loading branch information...
danbev authored and jasnell committed Apr 20, 2017
1 parent 9077b48 commit bde26a62bfeb70b642b04bed401c03ba6f1de936
Showing with 0 additions and 2 deletions.
  1. +0 −2 src/
@@ -940,8 +940,6 @@ Local<Value> UVException(Isolate* isolate,
Local<Object> e = Exception::Error(js_msg)->ToObject(isolate);
// TODO(piscisaureus) errno should probably go; the user has no way of
// knowing which uv errno value maps to which error.
e->Set(env->errno_string(), Integer::New(isolate, errorno));
e->Set(env->code_string(), js_code);
e->Set(env->syscall_string(), js_syscall);

0 comments on commit bde26a6

Please sign in to comment.