Permalink
Browse files

test: fix `fs-watch-recursive` flakiness on OS X

The test is sometimes timing out because of a race condition between
the fs event generated on file creation and the event being registered
in the kqueue. To avoid this problem, create the file after 100 ms,
that is the value used in the `fs_event_watch_dir_recursive` libuv test.

PR-URL: #4629
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information...
santigimeno authored and Fishrock123 committed Jan 11, 2016
1 parent 372e4f3 commit c07e063dd9be12d04d27717c96251db8ef366d43
Showing with 7 additions and 1 deletion.
  1. +7 −1 test/parallel/test-fs-watch-recursive.js
@@ -34,7 +34,13 @@ watcher.on('change', function(event, filename) {
watcherClosed = true;
});
fs.writeFileSync(filepathOne, 'world');
if (process.platform === 'darwin') {
setTimeout(function() {
fs.writeFileSync(filepathOne, 'world');
}, 100);
} else {
fs.writeFileSync(filepathOne, 'world');
}
process.on('exit', function() {
assert(watcherClosed, 'watcher Object was not closed');

0 comments on commit c07e063

Please sign in to comment.