Skip to content
Permalink
Browse files

test: make sure tmpdir is created before using it

Otherwise it throws ENOENT when the folder happens to be cleaned

PR-URL: #25224
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
joyeecheung authored and addaleax committed Dec 26, 2018
1 parent 1ccaf9a commit c10b131ec95efbbe34111c18c31642e5714c47df
Showing with 4 additions and 1 deletion.
  1. +4 −1 test/parallel/test-child-process-spawnsync-args.js
@@ -15,6 +15,8 @@ const tmpdir = require('../common/tmpdir');
const command = common.isWindows ? 'cd' : 'pwd';
const options = { cwd: tmpdir.path };

tmpdir.refresh();

if (common.isWindows) {
// This test is not the case for Windows based systems
// unless the `shell` options equals to `true`
@@ -31,12 +33,13 @@ const testCases = [
const expectedResult = tmpdir.path.trim().toLowerCase();

const results = testCases.map((testCase) => {
const { stdout, stderr } = spawnSync(
const { stdout, stderr, error } = spawnSync(
command,
testCase,
options
);

assert.ifError(error);
assert.deepStrictEqual(stderr, Buffer.alloc(0));

return stdout.toString().trim().toLowerCase();

0 comments on commit c10b131

Please sign in to comment.
You can’t perform that action at this time.