Permalink
Browse files

test: replace common.PORT with `0` in https renegotiation test

Repeated use of common.PORT was resulting in sporadic failures on some
operating systems.

PR-URL: #25599
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information...
Trott committed Jan 21, 2019
1 parent e3f917e commit c33d38b449fe7d2625eec6bedf3c9b891749f0cf
Showing with 3 additions and 2 deletions.
  1. +3 −2 test/pummel/test-https-ci-reneg-attack.js
@@ -65,8 +65,9 @@ function test(next) {
res.end('ok');
});

server.listen(common.PORT, function() {
const args = (`s_client -connect 127.0.0.1:${common.PORT}`).split(' ');
server.listen(0, function() {
const cmd = `s_client -connect 127.0.0.1:${server.address().port}`;
const args = cmd.split(' ');
const child = spawn(common.opensslCli, args);

child.stdout.resume();

0 comments on commit c33d38b

Please sign in to comment.