Please sign in to comment.
build: always use V8_ENABLE_CHECKS in debug mode
Define `V8_ENABLE_CHECKS` in `common.gypi` for the debug mode. Without this, these checks would only be present in the object files generated from the V8 build, and so for inline functions in v8.h multiple different definitions could be generated, where one definition includes the check and the other does not. Refs: #11975 (comment) PR-URL: #12029 Reviewed-By: Ben Noordhuis <firstname.lastname@example.org> Reviewed-By: Daniel Bevenius <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Colin Ihrig <email@example.com> Reviewed-By: Jason Ginchereau <firstname.lastname@example.org> Reviewed-By: Hitesh Kanwathirtha <email@example.com>
- Loading branch information...