Permalink
Browse files

build: always use V8_ENABLE_CHECKS in debug mode

Define `V8_ENABLE_CHECKS` in `common.gypi` for the debug mode.
Without this, these checks would only be present in the object files
generated from the V8 build, and so for inline functions in v8.h
multiple different definitions could be generated, where one definition
includes the check and the other does not.

Refs: #11975 (comment)
PR-URL: #12029
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
  • Loading branch information...
addaleax committed Mar 24, 2017
1 parent 241de51 commit c68da89694b1ff4682131ed6b825e596188cc4ed
Showing with 1 addition and 1 deletion.
  1. +1 −1 common.gypi
View
@@ -78,7 +78,7 @@
'variables': {
'v8_enable_handle_zapping': 1,
},
- 'defines': [ 'DEBUG', '_DEBUG' ],
+ 'defines': [ 'DEBUG', '_DEBUG', 'V8_ENABLE_CHECKS' ],
'cflags': [ '-g', '-O0' ],
'conditions': [
['target_arch=="x64"', {

0 comments on commit c68da89

Please sign in to comment.