Permalink
Browse files

test: make test-intl-no-icu-data more robust

In V8 5.6, String#toLocaleUpperCase can work even when no ICU data is
loaded. Use another method to check the --icu-data-dir option pointing
to an empty directory.

PR-URL: #10992
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information...
targos committed Feb 16, 2017
1 parent 7c0c7ba commit ca480719199d2ff38223aff8e301aced25d7e6f1
Showing with 1 addition and 2 deletions.
  1. +1 −2 test/parallel/test-intl-no-icu-data.js
@@ -4,6 +4,5 @@ require('../common');
const assert = require('assert');
const config = process.binding('config');
// No-op when ICU case mappings are unavailable.
assert.strictEqual('ç'.toLocaleUpperCase('el'), 'ç');
assert.deepStrictEqual(Intl.NumberFormat.supportedLocalesOf('en'), []);
assert.strictEqual(config.icuDataDir, 'test/fixtures/empty/');

0 comments on commit ca48071

Please sign in to comment.