From cb698111c487f0ecba43515d1ff0ea67377ca912 Mon Sep 17 00:00:00 2001
From: Anna Henningsen <anna@addaleax.net>
Date: Wed, 11 Jul 2018 01:28:30 +0200
Subject: [PATCH] src: add comment on CallbackScope exception behaviour

PR-URL: https://github.com/nodejs/node/pull/21743
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
---
 src/node.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/node.h b/src/node.h
index ed2c074b922687..305d605ef4a33a 100644
--- a/src/node.h
+++ b/src/node.h
@@ -683,6 +683,10 @@ class InternalCallbackScope;
  *
  * This object should be stack-allocated to ensure that it is contained in a
  * valid HandleScope.
+ *
+ * Exceptions happening within this scope will be treated like uncaught
+ * exceptions. If this behaviour is undesirable, a new `v8::TryCatch` scope
+ * needs to be created inside of this scope.
  */
 class NODE_EXTERN CallbackScope {
  public: