Permalink
Browse files

src: update v8_platform.StartInspector signature

The call signature of v8_platform.StartInspector needs to be the same
whether or not NODE_USE_V8_PLATFORM, otherwise Node will fail to compile
if HAVE_INSPECTOR and !NODE_USE_V8_PLATFORM.

(cherry picked from commit e619725)

PR-URL: #11157
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information...
mykmelez authored and italoacasas committed Jan 31, 2017
1 parent 7f9b436 commit ce3dcca619e40f6bcce620f2b7750d847a91b5c6
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/node.cc
View
@@ -227,7 +227,7 @@ static struct {
void PumpMessageLoop(Isolate* isolate) {}
void Dispose() {}
bool StartInspector(Environment *env, const char* script_path,
- int port, bool wait) {
+ const node::DebugOptions& options) {
env->ThrowError("Node compiled with NODE_USE_V8_PLATFORM=0");
return false; // make compiler happy
}

0 comments on commit ce3dcca

Please sign in to comment.