Please sign in to comment.
timers: truncate decimal values
Reverts some timers behavior back to as it was before 2930bd1 That commit introduced an unintended change which allowed non-integer timeouts to actually exist since the value is no longer converted to an integer via a TimeWrap handle directly. Even with the fix in e9de435 non-integer timeouts are still indeterministic, because libuv does not support them. This fixes the issue by emulating the old behavior: truncate the `_idleTimeout` before using it. See comments in #24214 for more background on this. PR-URL: #24819 Reviewed-By: Anatoli Papirovski <firstname.lastname@example.org> Reviewed-By: Anna Henningsen <email@example.com> Reviewed-By: Ruben Bridgewater <firstname.lastname@example.org> Reviewed-By: Trivikram Kamat <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org>
- Loading branch information...
Showing with 44 additions and 4 deletions.