Skip to content
Permalink
Browse files

deps,v8: silence V8 self-deprecation warnings

PR-URL: #25394
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
  • Loading branch information...
refack authored and addaleax committed Jan 8, 2019
1 parent eb5aab2 commit d1b7193428f6ed244e3937f718719312749b465e
Showing with 9 additions and 4 deletions.
  1. +5 −4 common.gypi
  2. +4 −0 deps/v8/gypfiles/features.gypi
@@ -45,12 +45,13 @@
# Old time default, now explicitly stated.
'v8_use_snapshot': 'true',

# These are more relevant for V8 internal development.
# Refs: https://github.com/nodejs/node/issues/23122
# Refs: https://github.com/nodejs/node/issues/23167
# Enable compiler warnings when using V8_DEPRECATED apis.
'v8_deprecation_warnings': 1,
# Enable compiler warnings when using V8_DEPRECATE_SOON apis.
'v8_imminent_deprecation_warnings': 1,
# Enable compiler warnings when using V8_DEPRECATED apis from V8 code.
'v8_deprecation_warnings': 0,
# Enable compiler warnings when using V8_DEPRECATE_SOON apis from V8 code.
'v8_imminent_deprecation_warnings': 0,

# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler': 1,
@@ -164,9 +164,13 @@
}],
['v8_deprecation_warnings==1', {
'defines': ['V8_DEPRECATION_WARNINGS',],
},{
'defines!': ['V8_DEPRECATION_WARNINGS',],
}],
['v8_imminent_deprecation_warnings==1', {
'defines': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
},{
'defines!': ['V8_IMMINENT_DEPRECATION_WARNINGS',],
}],
['v8_enable_i18n_support==1', {
'defines': ['V8_INTL_SUPPORT',],

0 comments on commit d1b7193

Please sign in to comment.
You can’t perform that action at this time.