Skip to content
Permalink
Browse files

build: warn upon --use-largepages config option

Emit a warning when the user configures with `--use-largepages` and/or
`--use-largepages-script-lld` informing them that the option is now
available as a Node.js runtime option once it is built.

Refs: #31063 (comment)
PR-URL: #31103
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
  • Loading branch information
gabrielschulhof authored and BridgeAR committed Dec 26, 2019
1 parent 97ce0a3 commit d2ab877b7253804451eb298664cef5349ed5d3e9
Showing with 7 additions and 0 deletions.
  1. +7 −0 configure.py
@@ -1067,6 +1067,13 @@ def configure_node(o):
else:
o['variables']['node_use_dtrace'] = 'false'

if options.node_use_large_pages or options.node_use_large_pages_script_lld:
warn('''The `--use-largepages` and `--use-largepages-script-lld` options
have no effect during build time. Support for mapping to large pages is
now a runtime option of Node.js. Run `node --use-largepages` or add
`--use-largepages` to the `NODE_OPTIONS` environment variable once
Node.js is built to enable mapping to large pages.''')

if options.no_ifaddrs:
o['defines'] += ['SUNOS_NO_IFADDRS']

0 comments on commit d2ab877

Please sign in to comment.
You can’t perform that action at this time.