Permalink
Browse files

test: refactor async-hooks/test-httparser tests

CRLF variable was defined but only used on line 22 so the variable
was deleted and placed inside line 22 as a string literal. This
was in file test-httpparser.request.js

On line 46 there's a function declared that takes 3 arguments but
none of them are ever used so removed. This is in file
test-httpparser.response.js

PR-URL: #14818
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Runite618 authored and tniessen committed Aug 13, 2017
1 parent 3f5d944 commit d4374ad6514b5825021597eb3fccdce241b66f70
Showing with 2 additions and 3 deletions.
  1. +1 −2 test/async-hooks/test-httpparser.request.js
  2. +1 −1 test/async-hooks/test-httpparser.response.js
@@ -9,7 +9,6 @@ const { checkInvocations } = require('./hook-checks');
const binding = process.binding('http_parser');
const HTTPParser = binding.HTTPParser;

const CRLF = '\r\n';
const REQUEST = HTTPParser.REQUEST;

const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
@@ -19,7 +18,7 @@ const hooks = initHooks();
hooks.enable();

const request = Buffer.from(
'GET /hello HTTP/1.1' + CRLF + CRLF
'GET /hello HTTP/1.1\r\n\r\n'
);

const parser = new HTTPParser(REQUEST);
@@ -43,7 +43,7 @@ function onheadersComplete() {
'when onheadersComplete called');
}

function onbody(buf, start, len) {
function onbody() {
checkInvocations(httpparser, { init: 1, before: 2, after: 1 },
'when onbody called');
tick(1, common.mustCall(tick1));

0 comments on commit d4374ad

Please sign in to comment.