Skip to content
Browse files

src: allow inspector without v8 platform

Embedders sometimes want to take control of V8 platform initialization
themselves, so we wouldn't want to experience an error if
NODE_USE_V8_PLATFORM was false necessarily. Instead, we can also gate
it with HAVE_INSPECTOR to allow embedders to define that themselves
and use Inspector without NODE_USE_V8_PLATFORM.

PR-URL: #30049
Reviewed-By: Anna Henningsen <>
Reviewed-By: Minwoo Jung <>
Reviewed-By: Joyee Cheung <>
Reviewed-By: David Carlier <>
Reviewed-By: Colin Ihrig <>
Reviewed-By: Gireesh Punathil <>
Reviewed-By: Anto Aravinth <>
  • Loading branch information
codebytere authored and targos committed Oct 21, 2019
1 parent c4c8e01 commit d586070388db7c754d7e819f3a36ad6b4a7be46a
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/
@@ -27,10 +27,10 @@ std::shared_ptr<PerProcessOptions> cli_options{new PerProcessOptions()};
} // namespace per_process

void DebugOptions::CheckOptions(std::vector<std::string>* errors) {
if (inspector_enabled) {
errors->push_back("Inspector is not available when Node is compiled "
"--without-v8-platform and --without-inspector.");

0 comments on commit d586070

Please sign in to comment.
You can’t perform that action at this time.