Skip to content
Permalink
Browse files

test: remove unused config

process.maxTickDepth was removed in v0.12 a whole while ago and was
mostly removed from our code base. There are still some places it was
left in old benchmarks and tests.

This PR removes setting the value in those tests and
benchmarks.

PR-URL: #21985
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
  • Loading branch information...
benjamingr authored and maclover7 committed Jul 26, 2018
1 parent 8d15f69 commit d68f946fe4ebaba02d68f5b118d53ec397ac705e
@@ -5,8 +5,6 @@ const bench = common.createBenchmark(main, {
n: [12e6]
});

process.maxTickDepth = Infinity;

function main({ n }) {
let counter = n;
function cb4(arg1, arg2, arg3, arg4) {
@@ -4,8 +4,6 @@ const bench = common.createBenchmark(main, {
n: [12e6]
});

process.maxTickDepth = Infinity;

function main({ n }) {
let counter = n;
bench.start();
@@ -23,12 +23,8 @@
require('../common');
const assert = require('assert');

// this is the inverse of test-next-tick-starvation.
// it verifies that process.nextTick will *always* come before other
// events, up to the limit of the process.maxTickDepth value.

// WARNING: unsafe!
process.maxTickDepth = Infinity;
// this is the inverse of test-next-tick-starvation. it verifies
// that process.nextTick will *always* come before other events

let ran = false;
let starved = false;
@@ -22,13 +22,13 @@
'use strict';
const common = require('../common');
const Readable = require('stream').Readable;

// This tests synchronous read callbacks and verifies that even if they nest
// heavily the process handles it without an error

const r = new Readable();
const N = 256 * 1024;

// Go ahead and allow the pathological case for this test.
// Yes, it's an infinite loop, that's the point.
process.maxTickDepth = N + 2;

let reads = 0;
r._read = function(n) {
const chunk = reads++ === N ? null : Buffer.allocUnsafe(1);
@@ -39,7 +39,6 @@ if (process.argv[2] !== 'child') {

const domain = require('domain');
const d = domain.create();
process.maxTickDepth = 10;

// in the error handler, we trigger several MakeCallback events
d.on('error', function() {

0 comments on commit d68f946

Please sign in to comment.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.