util: isEqualBoxedPrimitive: ensure both values are actual boxed Symbols

... before trying to valueOf them
nodejs · Aug 7, 2019 · d90707a · d90707a
1 parent 9f53778
commit d90707a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -98,8 +98,11 @@ function isEqualBoxedPrimitive(val1, val2) {
     return isBigIntObject(val2) &&
            BigIntPrototype.valueOf(val1) === BigIntPrototype.valueOf(val2);
   }
-  return isSymbolObject(val2) &&
-         SymbolPrototype.valueOf(val1) === SymbolPrototype.valueOf(val2);
+  if (isSymbolObject(val1)) {
+    return isSymbolObject(val2) &&
+          SymbolPrototype.valueOf(val1) === SymbolPrototype.valueOf(val2);
+  }
+  return false;
 }
 
 // Notes: Type tags are historical [[Class]] properties that can be set by