From d9d9d23191c57ed1450315ba7c3ceca451e8d412 Mon Sep 17 00:00:00 2001
From: "Giovanny Andres Gongora Granada (Gioyik)" <gioyik@gmail.com>
Date: Sat, 22 Sep 2018 02:28:03 -0500
Subject: [PATCH] errors: fix ERR_SOCKET_BAD_PORT message

The current message says 'Port should be > 0' meaning '0' is an
invalid value. You can pass '0' to get a random port from the system.
The correct message for this error is 'Port should be >= 0'.

PR-URL: https://github.com/nodejs/node/pull/23015
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
---
 doc/api/errors.md                     | 2 +-
 lib/internal/errors.js                | 2 +-
 test/parallel/test-dns.js             | 2 +-
 test/parallel/test-internal-errors.js | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/api/errors.md b/doc/api/errors.md
index 860e53c2018359..dcb2c77a7bf353 100644
--- a/doc/api/errors.md
+++ b/doc/api/errors.md
@@ -1526,7 +1526,7 @@ An invalid (negative) size was passed for either the `recvBufferSize` or
 <a id="ERR_SOCKET_BAD_PORT"></a>
 ### ERR_SOCKET_BAD_PORT
 
-An API function expecting a port > 0 and < 65536 received an invalid value.
+An API function expecting a port >= 0 and < 65536 received an invalid value.
 
 <a id="ERR_SOCKET_BAD_TYPE"></a>
 ### ERR_SOCKET_BAD_TYPE
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
index 4fc43f1a6cbe7e..6153f7e2994605 100644
--- a/lib/internal/errors.js
+++ b/lib/internal/errors.js
@@ -808,7 +808,7 @@ E('ERR_SOCKET_ALREADY_BOUND', 'Socket is already bound', Error);
 E('ERR_SOCKET_BAD_BUFFER_SIZE',
   'Buffer size must be a positive integer', TypeError);
 E('ERR_SOCKET_BAD_PORT',
-  'Port should be > 0 and < 65536. Received %s.', RangeError);
+  'Port should be >= 0 and < 65536. Received %s.', RangeError);
 E('ERR_SOCKET_BAD_TYPE',
   'Bad socket type specified. Valid types are: udp4, udp6', TypeError);
 E('ERR_SOCKET_BUFFER_SIZE',
diff --git a/test/parallel/test-dns.js b/test/parallel/test-dns.js
index dcef59e43f90a1..a618bccd89ac13 100644
--- a/test/parallel/test-dns.js
+++ b/test/parallel/test-dns.js
@@ -290,7 +290,7 @@ const portErr = (port) => {
   const err = {
     code: 'ERR_SOCKET_BAD_PORT',
     message:
-      `Port should be > 0 and < 65536. Received ${port}.`,
+      `Port should be >= 0 and < 65536. Received ${port}.`,
     type: RangeError
   };
 
diff --git a/test/parallel/test-internal-errors.js b/test/parallel/test-internal-errors.js
index be93598e068464..d4f6a443d82f4c 100644
--- a/test/parallel/test-internal-errors.js
+++ b/test/parallel/test-internal-errors.js
@@ -129,7 +129,7 @@ assert.strictEqual(errors.getMessage('ERR_MISSING_ARGS', ['a', 'b', 'c']),
 // Test ERR_SOCKET_BAD_PORT
 assert.strictEqual(
   errors.getMessage('ERR_SOCKET_BAD_PORT', [0]),
-  'Port should be > 0 and < 65536. Received 0.');
+  'Port should be >= 0 and < 65536. Received 0.');
 
 // Test ERR_TLS_CERT_ALTNAME_INVALID
 assert.strictEqual(