Skip to content

Commit

Permalink
http2: remove --expose-http2 flag from tests, etc
Browse files Browse the repository at this point in the history
Remove the --expose-http2 flag from tests and benchmarks

PR-URL: #15685
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
  • Loading branch information
jasnell authored and evanlucas committed Oct 23, 2017
1 parent 57ab6e2 commit e01daec
Show file tree
Hide file tree
Showing 131 changed files with 81 additions and 138 deletions.
2 changes: 1 addition & 1 deletion benchmark/http2/headers.js
Expand Up @@ -6,7 +6,7 @@ const PORT = common.PORT;
const bench = common.createBenchmark(main, {
n: [1e3],
nheaders: [0, 10, 100, 1000],
}, { flags: ['--expose-http2', '--no-warnings'] });
}, { flags: ['--no-warnings'] });

function main(conf) {
const n = +conf.n;
Expand Down
2 changes: 1 addition & 1 deletion benchmark/http2/respond-with-fd.js
Expand Up @@ -11,7 +11,7 @@ const bench = common.createBenchmark(main, {
requests: [100, 1000, 10000, 100000, 1000000],
streams: [100, 200, 1000],
clients: [1, 2]
}, { flags: ['--expose-http2', '--no-warnings'] });
}, { flags: ['--no-warnings'] });

function main(conf) {

Expand Down
2 changes: 1 addition & 1 deletion benchmark/http2/simple.js
Expand Up @@ -12,7 +12,7 @@ const bench = common.createBenchmark(main, {
requests: [100, 1000, 10000, 100000],
streams: [100, 200, 1000],
clients: [1, 2]
}, { flags: ['--expose-http2', '--no-warnings'] });
}, { flags: ['--no-warnings'] });

function main(conf) {
const n = +conf.requests;
Expand Down
2 changes: 1 addition & 1 deletion benchmark/http2/write.js
Expand Up @@ -7,7 +7,7 @@ const bench = common.createBenchmark(main, {
streams: [100, 200, 1000],
length: [64 * 1024, 128 * 1024, 256 * 1024, 1024 * 1024],
size: [100000]
}, { flags: ['--expose-http2', '--no-warnings'] });
}, { flags: ['--no-warnings'] });

function main(conf) {
const m = +conf.streams;
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-binding.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-data-end.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-destroy.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-onconnect-errors.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const {
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-priority-before-connect.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-promisify-connect.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-request-options-errors.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-set-priority.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-settings-before-connect.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-shutdown-before-connect.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-socket-destroy.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-unescaped-path.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-upload.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

// Verifies that uploading data from a client works
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-client-write-before-connect.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-compat-errors.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2 --expose-internals
// Flags: --expose-internals
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-expect-continue-check.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-expect-continue.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-expect-handling.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-method-connect.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverrequest-end.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverrequest-headers.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverrequest-pause.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverrequest-pipe.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverrequest-trailers.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverrequest.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-compat-serverresponse-close.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2 --expose-internals
// Flags: --expose-internals
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverresponse-destroy.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverresponse-drain.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverresponse-end.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const {
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverresponse-finished.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverresponse-headers.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-compat-serverresponse-trailers.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const { mustCall,
Expand Down
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-connect-method.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-connect.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const { mustCall, hasCrypto, skip, expectsError } = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-cookies.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-create-client-connect.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

// Tests http2.connect()
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-create-client-secure-session.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-create-client-session.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
1 change: 0 additions & 1 deletion test/parallel/test-http2-createsecureserver-nooptions.js
@@ -1,4 +1,3 @@
// Flags: --expose-http2
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-createwritereq.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-date-header.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-dont-override.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-getpackedsettings.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-goaway-opaquedata.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-head-request.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-https-fallback.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-info-headers.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-max-concurrent-streams.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-methods.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-misused-pseudoheaders.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-multi-content-length.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-multiheaders-raw.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-multiheaders.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-multiplex.js
@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

// Tests opening 100 concurrent simultaneous uploading streams over a single
Expand Down
8 changes: 0 additions & 8 deletions test/parallel/test-http2-noflag.js

This file was deleted.

@@ -1,4 +1,4 @@
// Flags: --expose-http2
//
'use strict';

const common = require('../common');
Expand Down

0 comments on commit e01daec

Please sign in to comment.