Skip to content
Permalink
Browse files

lib,test: remove lib/internal/test/unicode.js

Remove lib/internal/test/unicode.js and associated test. When we added
the file and test, only comments in lib had non-ASCII characters. Now,
lib/internal/cli_table.js has non-ASCII characters. Tests that exercise
the `console.table()` therefore fulfill the need to test non-ASCII
characters in built-in modules.

PR-URL: #25298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Trott authored and addaleax committed Jan 1, 2019
1 parent 9101591 commit e14f8646e2f5daadfbc79aab5b9a4aa06585e8af
Showing with 6 additions and 21 deletions.
  1. +6 −0 lib/internal/cli_table.js
  2. +0 −8 lib/internal/test/unicode.js
  3. +0 −1 node.gyp
  4. +0 −12 test/parallel/test-internal-unicode.js
@@ -4,6 +4,12 @@ const { Buffer } = require('buffer');
const { removeColors } = require('internal/util');
const HasOwnProperty = Function.call.bind(Object.prototype.hasOwnProperty);

// The use of Unicode characters below is the only non-comment use of non-ASCII
// Unicode characters in Node.js built-in modules. If they are ever removed or
// rewritten with \u escapes, then a test will need to be (re-)added to Node.js
// core to verify that Unicode characters work in built-ins. Otherwise,
// consumers using Unicode in _third_party_main.js will run into problems.
// Refs: https://github.com/nodejs/node/issues/10673
const tableChars = {
/* eslint-disable node-core/non-ascii-character */
middleMiddle: '',

This file was deleted.

@@ -159,7 +159,6 @@
'lib/internal/socket_list.js',
'lib/internal/test/binding.js',
'lib/internal/test/heap.js',
'lib/internal/test/unicode.js',
'lib/internal/timers.js',
'lib/internal/tls.js',
'lib/internal/trace_events_async_hooks.js',

This file was deleted.

0 comments on commit e14f864

Please sign in to comment.
You can’t perform that action at this time.