Skip to content
Permalink
Browse files

src: run RunBeforeExitCallbacks as part of EmitBeforeExit

This is part of a series of changes to make embedding easier, by
requiring fewer internal methods to build a fully functioning
Node.js instance.

This also aligns the worker_threads code with the main thread code.

PR-URL: #30229
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
  • Loading branch information
addaleax authored and MylesBorins committed Nov 2, 2019
1 parent da8ceb9 commit e1a12446c52925815cfc07c90ddc96628ea8e59a
Showing with 2 additions and 2 deletions.
  1. +2 −0 src/api/hooks.cc
  2. +0 −2 src/node_main_instance.cc
@@ -30,6 +30,8 @@ void AtExit(Environment* env, void (*cb)(void* arg), void* arg) {
}

void EmitBeforeExit(Environment* env) {
env->RunBeforeExitCallbacks();

HandleScope handle_scope(env->isolate());
Context::Scope context_scope(env->context());
Local<Value> exit_code = env->process_object()
@@ -133,8 +133,6 @@ int NodeMainInstance::Run() {
more = uv_loop_alive(env->event_loop());
if (more && !env->is_stopping()) continue;

env->RunBeforeExitCallbacks();

if (!uv_loop_alive(env->event_loop())) {
EmitBeforeExit(env.get());
}

0 comments on commit e1a1244

Please sign in to comment.
You can’t perform that action at this time.