From e4f802de9a4c4c653b61d067d640a6bfe6d8b6e5 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 18 Jun 2021 22:27:10 -0700 Subject: [PATCH] debugger: rename internal library for clarity When I moved these files from node-inspect to Node.js core, I put them in lib/internal/inspector. That was a mistake. They should be in lib/internal/debugger. PR-URL: https://github.com/nodejs/node/pull/39080 Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig --- lib/internal/{inspector => debugger}/_inspect.js | 4 ++-- lib/internal/{inspector => debugger}/inspect_client.js | 0 lib/internal/{inspector => debugger}/inspect_repl.js | 0 lib/internal/main/inspect.js | 2 +- node.gyp | 6 +++--- 5 files changed, 6 insertions(+), 6 deletions(-) rename lib/internal/{inspector => debugger}/_inspect.js (98%) rename lib/internal/{inspector => debugger}/inspect_client.js (100%) rename lib/internal/{inspector => debugger}/inspect_repl.js (100%) diff --git a/lib/internal/inspector/_inspect.js b/lib/internal/debugger/_inspect.js similarity index 98% rename from lib/internal/inspector/_inspect.js rename to lib/internal/debugger/_inspect.js index e2309fcc68c268..7f1017886f6d6e 100644 --- a/lib/internal/inspector/_inspect.js +++ b/lib/internal/debugger/_inspect.js @@ -39,8 +39,8 @@ const console = require('internal/console/global'); const { 0: InspectClient, 1: createRepl } = [ - require('internal/inspector/inspect_client'), - require('internal/inspector/inspect_repl'), + require('internal/debugger/inspect_client'), + require('internal/debugger/inspect_repl'), ]; const debuglog = util.debuglog('inspect'); diff --git a/lib/internal/inspector/inspect_client.js b/lib/internal/debugger/inspect_client.js similarity index 100% rename from lib/internal/inspector/inspect_client.js rename to lib/internal/debugger/inspect_client.js diff --git a/lib/internal/inspector/inspect_repl.js b/lib/internal/debugger/inspect_repl.js similarity index 100% rename from lib/internal/inspector/inspect_repl.js rename to lib/internal/debugger/inspect_repl.js diff --git a/lib/internal/main/inspect.js b/lib/internal/main/inspect.js index d9dab0dc92b118..44923e5383ff5f 100644 --- a/lib/internal/main/inspect.js +++ b/lib/internal/main/inspect.js @@ -13,5 +13,5 @@ markBootstrapComplete(); // Start the debugger agent. process.nextTick(() => { - require('internal/inspector/_inspect').start(); + require('internal/debugger/_inspect').start(); }); diff --git a/node.gyp b/node.gyp index 3f674c978d2788..1de9edc07f610d 100644 --- a/node.gyp +++ b/node.gyp @@ -143,6 +143,9 @@ 'lib/internal/crypto/webcrypto.js', 'lib/internal/crypto/x509.js', 'lib/internal/constants.js', + 'lib/internal/debugger/_inspect.js', + 'lib/internal/debugger/inspect_client.js', + 'lib/internal/debugger/inspect_repl.js', 'lib/internal/dgram.js', 'lib/internal/dns/promises.js', 'lib/internal/dns/utils.js', @@ -166,9 +169,6 @@ 'lib/internal/heap_utils.js', 'lib/internal/histogram.js', 'lib/internal/idna.js', - 'lib/internal/inspector/_inspect.js', - 'lib/internal/inspector/inspect_client.js', - 'lib/internal/inspector/inspect_repl.js', 'lib/internal/inspector_async_hook.js', 'lib/internal/js_stream_socket.js', 'lib/internal/legacy/processbinding.js',