Skip to content
Permalink
Browse files

stream: inline and simplify onwritedrain

Inline and simplify onwritedrain. Also remove comment that seems to be
outdated/invalid.

PR-URL: #29037
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information...
ronag authored and targos committed Aug 7, 2019
1 parent c396b2a commit e543d35f3541baeb19b7f23fcbd0051d1be48448
Showing with 4 additions and 12 deletions.
  1. +4 −12 lib/_stream_writable.js
@@ -478,21 +478,13 @@ function onwrite(stream, er) {
}

function afterWrite(stream, state, finished, cb) {
if (!finished)
onwriteDrain(stream, state);
state.pendingcb--;
cb();
finishMaybe(stream, state);
}

// Must force callback to be called on nextTick, so that we don't
// emit 'drain' before the write() consumer gets the 'false' return
// value, and has a chance to attach a 'drain' listener.
function onwriteDrain(stream, state) {
if (state.length === 0 && state.needDrain) {
if (!finished && state.length === 0 && state.needDrain) {
state.needDrain = false;
stream.emit('drain');
}
state.pendingcb--;
cb();
finishMaybe(stream, state);
}

// If there's something in the buffer waiting, then process it

0 comments on commit e543d35

Please sign in to comment.
You can’t perform that action at this time.