Please sign in to comment.
src: remove out-of-date TODO comment
This commit attempts to fix one of the items in #4641, which was to remove a TODO the UDPWrap::OnSend function and share the code in that method with StreamWrap::AfterWrite. While looking into this addaleax pointed out that the implementations for these two functions have diverged since the original comment was added: $ git log --pretty=short -u -L 357,357:src/udp_wrap.cc $ git show cbd4033:src/udp_wrap.cc | grep -1 -A26 'UDPWrap::OnSend' git show cbd4033:src/stream_wrap.cc | grep -A27 'void StreamWrap::AfterWrite' Removing the TODO comment seems appropriate in this case. PR-URL: #9000 Reviewed-By: James M Snell <email@example.com> Reviewed-By: Colin Ihrig <firstname.lastname@example.org> Reviewed-By: Ben Noordhuis <email@example.com>
- Loading branch information...