Permalink
Browse files

test: fix flaky test-gc-net-timeout

There's a global.gc() invoked in an interval, and a second one in a
req.setTimeout() callback. Remove the one in the callback. I'm not sure
how competing global.gc() calls might result in a deadlock, but it seems
plausible and empirical testing confirms that it makes the test
reliable.

Fixes: #23067

PR-URL: #23139
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
Trott committed Sep 27, 2018
1 parent 27f3d9a commit ea232bd320c4b15c1d07b2d3bafb565725f1e8f0
Showing with 0 additions and 1 deletion.
  1. +0 −1 test/sequential/test-gc-net-timeout.js
@@ -41,7 +41,6 @@ function getall() {
req.setTimeout(10, function() {
req.destroy();
done++;
global.gc();
});
count++;

0 comments on commit ea232bd

Please sign in to comment.