Permalink
Browse files

build: disable -O3 for C++ coverage

The `cflags` for `--coverage` included `-O0` so far, but that was
overridden by a later `-O3`. Resolve that by adding
`'cflags!': [ '-O3' ]` and increase coverage accuracy.

Ref: https://coverage.nodejs.org/
PR-URL: #12406
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
addaleax authored and refack committed Apr 13, 2017
1 parent 3d2181c commit ea44b8b283a7b056ebf194e4187e393bbd1ae651
Showing with 2 additions and 1 deletion.
  1. +2 −1 node.gypi
View
@@ -325,7 +325,8 @@
'-O0' ],
'cflags': [ '--coverage',
'-g',
'-O0' ]
'-O0' ],
'cflags!': [ '-O3' ]
}],
[ 'OS=="sunos"', {
'ldflags': [ '-Wl,-M,/usr/lib/ld/map.noexstk' ],

0 comments on commit ea44b8b

Please sign in to comment.