Skip to content
Permalink
Browse files

test: remove deepStrictEqual() third argument

The call to assert.deepStrictEqual() has a string literal for its third
argument. Unfortunately, a side effect of that is that the values of the
first two arguments are not displayed if there is an AssertionError.
That information is useful for debugging.

PR-URL: #20702
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information...
ceccode authored and Trott committed May 13, 2018
1 parent 0e9ea35 commit eafb30ccbf12a4ded74a30d7634e84fbe4a5add3
Showing with 2 additions and 2 deletions.
  1. +2 −2 test/parallel/test-net-socket-local-address.js
@@ -17,8 +17,8 @@ const server = net.createServer((socket) => {
});

server.on('close', common.mustCall(() => {
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts,
'client and server should agree on the ports used');
// client and server should agree on the ports used
assert.deepStrictEqual(clientLocalPorts, serverRemotePorts);
assert.strictEqual(2, conns);
}));

0 comments on commit eafb30c

Please sign in to comment.
You can’t perform that action at this time.