Skip to content
Browse files
build: add CONFIG_FLAGS to with-code-cache target
This commit adds CONFIG_FLAGS to allow the with-code-cache target to be
used with a debug build. The motivation for this is to make it easier to
debug a build with the code cache enabled.

The suggested usage:
$ make BUILDTYPE=Debug with-code-cache

The BUILDTYPE option is not needed if ./configure was already
configured with --debug.

PR-URL: #22207
Reviewed-By: Richard Lau <>
Reviewed-By: Joyee Cheung <>
Reviewed-By: Refael Ackermann <>
Reviewed-By: Jon Moss <>
  • Loading branch information
danbev authored and maclover7 committed Aug 12, 2018
1 parent 30b5b84 commit ec8f31dacead7cabf334132f289961caea7033ec
Showing with 6 additions and 2 deletions.
  1. +6 −2 Makefile
@@ -94,13 +94,17 @@ $(NODE_G_EXE): config.gypi out/Makefile
CODE_CACHE_DIR ?= out/$(BUILDTYPE)/obj/gen

ifeq ($(BUILDTYPE),Debug)
CONFIG_FLAGS += --debug
.PHONY: with-code-cache
$(PYTHON) ./configure
$(PYTHON) ./configure $(CONFIG_FLAGS)
mkdir -p $(CODE_CACHE_DIR)
out/$(BUILDTYPE)/$(NODE_EXE) --expose-internals tools/generate_code_cache.js $(CODE_CACHE_FILE)
$(PYTHON) ./configure --code-cache-path $(CODE_CACHE_FILE)
$(PYTHON) ./configure --code-cache-path $(CODE_CACHE_FILE) $(CONFIG_FLAGS)

.PHONY: test-code-cache

0 comments on commit ec8f31d

Please sign in to comment.