From f0e720a7fa48adb764b534ebfa32a77bea6e7864 Mon Sep 17 00:00:00 2001 From: Abdirahim Musse <33973272+abmusse@users.noreply.github.com> Date: Thu, 12 Oct 2023 19:13:09 +0000 Subject: [PATCH] test: add EOVERFLOW as an allowed error in test-fs-read-promises-position-validation.mjs As stated in https://github.com/nodejs/node/issues/50054 This looks like an oversight as test-fs-read-position-validation.mjs includes EOVERFLOW as an allowed error. Fixes https://github.com/nodejs/node/issues/50054 PR-URL: https://github.com/nodejs/node/pull/50128 Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Yagiz Nizipli --- test/parallel/test-fs-read-promises-position-validation.mjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-fs-read-promises-position-validation.mjs b/test/parallel/test-fs-read-promises-position-validation.mjs index 1531a002b01fb0..8bc238d3f269f4 100644 --- a/test/parallel/test-fs-read-promises-position-validation.mjs +++ b/test/parallel/test-fs-read-promises-position-validation.mjs @@ -62,9 +62,9 @@ async function testInvalid(code, position) { await testValid(1n); await testValid(9); await testValid(9n); - await testValid(Number.MAX_SAFE_INTEGER, [ 'EFBIG' ]); + await testValid(Number.MAX_SAFE_INTEGER, [ 'EFBIG', 'EOVERFLOW']); - await testValid(2n ** 63n - 1n - BigInt(length), [ 'EFBIG' ]); + await testValid(2n ** 63n - 1n - BigInt(length), [ 'EFBIG', 'EOVERFLOW']); await testInvalid('ERR_OUT_OF_RANGE', 2n ** 63n); await testInvalid('ERR_OUT_OF_RANGE', 2n ** 63n - BigInt(length));