Skip to content
Permalink
Browse files
test: remove third argument from assert.strictEqual()
`test/parallel/test-util-inspect.js` has a call to
`assert.strictEqual()` that receives three arguments.
The third argument is a string literal. Unfortunately,
calling assert.strictEqual() this way means that if
there is an AssertionError, the value of the variables
pos and npos are not reported.
This PR removes this argument.

PR-URL: #22371
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
  • Loading branch information
diprudnikov authored and George Adams committed Aug 20, 2018
1 parent 28675b6 commit f1d3f97c3bc813528e85b9c3e6506fc75b931d92
Showing with 1 addition and 1 deletion.
  1. +1 −1 test/parallel/test-util-inspect.js
@@ -979,7 +979,7 @@ if (typeof Symbol !== 'undefined') {
const npos = line.search(numRE);
if (npos !== -1) {
if (pos !== undefined) {
assert.strictEqual(pos, npos, 'container items not aligned');
assert.strictEqual(pos, npos);
}
pos = npos;
}

0 comments on commit f1d3f97

Please sign in to comment.