Permalink
Browse files

test: improve path tests

Replaced deepStrictEqual with strictEqual when asserting that the
path is equal to the win32 or posix equivalent, since it is a more
strict check than deepStrictCheck. Also removed third argument
in the check so that if there is an assertion error the properties
that are different will be displayed.

PR-URL: #20967
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Shivang44 authored and apapirovski committed May 25, 2018
1 parent cf72301 commit f49bd39cdefce968793c8891774df7a02f67b5ac
Showing with 2 additions and 2 deletions.
  1. +2 −2 test/parallel/test-path.js
@@ -68,6 +68,6 @@ assert.strictEqual(path.win32.delimiter, ';');
assert.strictEqual(path.posix.delimiter, ':');
if (common.isWindows)
assert.deepStrictEqual(path, path.win32, 'should be win32 path module');
assert.strictEqual(path, path.win32);
else
assert.deepStrictEqual(path, path.posix, 'should be posix path module');
assert.strictEqual(path, path.posix);

0 comments on commit f49bd39

Please sign in to comment.