Permalink
Browse files

test: remove message from strictEqual assertions

If values are not equals in strictEqual assertions, an AssertionError is
thrown with a message property set equals to the value of the message
parameter. If we pass a message, this message will be printed instead of
the default message, which contains the value that is causing the error.
Hence removed the value passed as the message in strictEqual assertions
of test/parallel/test-http-response-readable.js

PR-URL: #20067
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information...
isurusiri authored and Trott committed Apr 16, 2018
1 parent be92eab commit f565bbb193c90a974ad1500b86047b834d58606d
Showing with 2 additions and 3 deletions.
  1. +2 −3 test/parallel/test-http-response-readable.js
@@ -31,10 +31,9 @@ const testServer = new http.Server(function(req, res) {
testServer.listen(0, function() {
http.get({ port: this.address().port }, function(res) {
assert.strictEqual(res.readable, true, 'res.readable initially true');
assert.strictEqual(res.readable, true);
res.on('end', function() {
assert.strictEqual(res.readable, false,
'res.readable set to false after end');
assert.strictEqual(res.readable, false);
testServer.close();
});
res.resume();

0 comments on commit f565bbb

Please sign in to comment.