From f5d1bf9d0eddc429d6eedc1661867eaa20d29b0e Mon Sep 17 00:00:00 2001 From: Qingyu Deng Date: Wed, 10 Feb 2021 13:10:36 +0800 Subject: [PATCH] http: explain the possibilty of refactor unused argument PR-URL: https://github.com/nodejs/node/pull/37275 Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen Reviewed-By: Matteo Collina --- lib/_http_incoming.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/_http_incoming.js b/lib/_http_incoming.js index 18121830b5048b..2e440e3f1b1992 100644 --- a/lib/_http_incoming.js +++ b/lib/_http_incoming.js @@ -156,6 +156,10 @@ IncomingMessage.prototype.setTimeout = function setTimeout(msecs, callback) { // argument adaptor frame creation inside V8 in case that number of actual // arguments is different from expected arguments. // Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10201 +// NOTE: Argument adapt frame issue might be solved in V8 engine v8.9. +// Refactoring `n` out might be possible when V8 is upgraded to that +// version. +// Ref: https://v8.dev/blog/v8-release-89 IncomingMessage.prototype._read = function _read(n) { if (!this._consuming) { this._readableState.readingMore = false;