From fa7d0ce4860cd96d900dd86ca6af294e61fcd229 Mon Sep 17 00:00:00 2001 From: MarianneDr Date: Fri, 12 Oct 2018 10:37:02 -0700 Subject: [PATCH] src: remove unused UVHandle methods PR-URL: https://github.com/nodejs/node/pull/23535 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell --- src/connection_wrap.h | 4 ---- src/tty_wrap.cc | 5 ----- src/tty_wrap.h | 2 -- src/udp_wrap.cc | 7 ------- src/udp_wrap.h | 2 -- 5 files changed, 20 deletions(-) diff --git a/src/connection_wrap.h b/src/connection_wrap.h index 72030a00901daf..5b114088760dad 100644 --- a/src/connection_wrap.h +++ b/src/connection_wrap.h @@ -12,10 +12,6 @@ namespace node { template class ConnectionWrap : public LibuvStreamWrap { public: - UVType* UVHandle() { - return &handle_; - } - static void OnConnection(uv_stream_t* handle, int status); static void AfterConnect(uv_connect_t* req, int status); diff --git a/src/tty_wrap.cc b/src/tty_wrap.cc index 516fa1ec1ff4ed..9522dee95bbfb8 100644 --- a/src/tty_wrap.cc +++ b/src/tty_wrap.cc @@ -64,11 +64,6 @@ void TTYWrap::Initialize(Local target, } -uv_tty_t* TTYWrap::UVHandle() { - return &handle_; -} - - void TTYWrap::GuessHandleType(const FunctionCallbackInfo& args) { Environment* env = Environment::GetCurrent(args); int fd; diff --git a/src/tty_wrap.h b/src/tty_wrap.h index ad5f364134e3e2..f794e2112fa1ee 100644 --- a/src/tty_wrap.h +++ b/src/tty_wrap.h @@ -36,8 +36,6 @@ class TTYWrap : public LibuvStreamWrap { v8::Local unused, v8::Local context); - uv_tty_t* UVHandle(); - SET_NO_MEMORY_INFO() SET_MEMORY_INFO_NAME(TTYWrap) SET_SELF_SIZE(TTYWrap) diff --git a/src/udp_wrap.cc b/src/udp_wrap.cc index 28fa51f1c639d2..04d65c3635737e 100644 --- a/src/udp_wrap.cc +++ b/src/udp_wrap.cc @@ -27,8 +27,6 @@ #include "req_wrap-inl.h" #include "util-inl.h" - - namespace node { using v8::Array; @@ -512,11 +510,6 @@ Local UDPWrap::Instantiate(Environment* env, } -uv_udp_t* UDPWrap::UVHandle() { - return &handle_; -} - - } // namespace node NODE_BUILTIN_MODULE_CONTEXT_AWARE(udp_wrap, node::UDPWrap::Initialize) diff --git a/src/udp_wrap.h b/src/udp_wrap.h index c1261fdb3945e4..c7e1411c08659f 100644 --- a/src/udp_wrap.h +++ b/src/udp_wrap.h @@ -62,8 +62,6 @@ class UDPWrap: public HandleWrap { static v8::Local Instantiate(Environment* env, AsyncWrap* parent, SocketType type); - uv_udp_t* UVHandle(); - SET_NO_MEMORY_INFO() SET_MEMORY_INFO_NAME(UDPWrap) SET_SELF_SIZE(UDPWrap)