Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: shared lib build doesn't handle SIGPIPE
For shared lib build, we leave the signal handling for embedding users. In these two test cases: - `parallel/test-process-external-stdio-close-spawn` - `parallel/test-process-external-stdio-close` The pipe is used for stdout and is destroied before child process uses it for logging. So the node executble that uses shared lib build receives SIGPIPE and the child process ends. This change ignores the SIGPIPE in node_main.cc for shared lib case. Refs: #18535 Signed-off-by: Yihong Wang <email@example.com> PR-URL: #19211 Refs: #18535 Reviewed-By: Ben Noordhuis <firstname.lastname@example.org> Reviewed-By: Colin Ihrig <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Michael Dawson <email@example.com> Reviewed-By: Gireesh Punathil <firstname.lastname@example.org>
- Loading branch information
Showing with 39 additions and 17 deletions.