Skip to content
Permalink
Branch: master
Commits on Mar 23, 2019
  1. timers: deprecate active() and _unrefActive()

    Fishrock123 committed Mar 18, 2019
    Another nail in the coffin here, farewell ye ol C-style apis.
    
    These apis caused numerous other issues that required far too many
    safeguards. This gets us one step closer to not having to worry about
    those issues anymore.
    
    Refs: #18066
    Refs: #20298
    
    PR-URL: #26760
    
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Commits on Mar 21, 2019
  1. timers: move big impl comment to /internal/

    Fishrock123 committed Mar 18, 2019
    To be paired with the commits from
    #26583
    
    Specifically:
    1a6fb71
    
    PR-URL: #26761
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Commits on Jan 29, 2019
  1. timers: truncate decimal values

    Fishrock123 committed Dec 4, 2018
    Reverts some timers behavior back to as it was before
    2930bd1
    
    That commit introduced an unintended change which allowed non-integer
    timeouts to actually exist since the value is no longer converted to an
    integer via a TimeWrap handle directly.
    
    Even with the fix in
    e9de435
    non-integer timeouts are still indeterministic, because libuv does not
    support them.
    
    This fixes the issue by emulating the old behavior:
    truncate the `_idleTimeout` before using it.
    
    See comments in
    #24214
    for more background on this.
    
    PR-URL: #24819
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jan 28, 2019
  1. test: rewrite fs {f}utimes test file

    Fishrock123 authored and addaleax committed Jan 23, 2019
    Previously this test silently swallowed some errors.
    
    Refactored to use `common.mustCall()` & `assert()`s.
    
    Also, this adds a couple of extra error-checking cases.
    
    PR-URL: #25656
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Jan 23, 2019
  1. child_process: truncate output when maxBuffer is exceeded

    Fishrock123 committed Dec 11, 2018
    Preserves truncated output for `child_process.exec()` when `maxBuffer`
    is exceeded.
    
    This is particularly useful for commands which have indistinguishable
    error codes for what output they produce.
    
    PR-URL: #24951
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  2. test: add stdio checks to cp-exec-maxBuffer

    Fishrock123 committed Dec 11, 2018
    Expands this test case to check what happens to stdout/stderr when
    maxBuffer is exceeded.
    
    Also changes how cases are checked so that assertion stacks are
    tracable to their test case, aka 'make it actually debuggable'.
    
    PR-URL: #24951
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Jun 12, 2018
  1. doc: fix reference to workerData in worker_threads

    Fishrock123 committed Jun 6, 2018
    This was previously incorrect.
    
    PR-URL: #21180
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  2. test: add workerdata-sharedarraybuffer test

    Fishrock123 committed Jun 6, 2018
    This functionality works but was previously untested.
    
    PR-URL: #21180
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on May 10, 2018
  1. timers: make timer.refresh() a public API

    Fishrock123 authored and ryzokuken committed Apr 25, 2018
    Originally added in
    bb5575a
    discussions such as
    #20261
    show the usefulness of this API to the Node.js ecosystem.
    
    PR-URL: #20298
    
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Commits on Feb 22, 2018
  1. test: really test the ttywrap bits of getasyncid

    Fishrock123 committed Feb 20, 2018
    Follow-up from #18800
    
    Code that tries to exercise tty fds must be placed in `/pseudo-tty/`.
    
    PR-URL: #18886
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Feb 20, 2018
  1. test: actually test tty `getColorDepth()`

    Fishrock123 committed Feb 16, 2018
    TTY tests should almost never be placed in `/parallel/`. Skipping TTY
    tests there due to missing tty fds just means they will never be run,
    ever, on any system.
    
    This moves the tty-get-color-depth test to `/pseudo-tty/` where the test
    runner will actually make a pty fd.
    
    Refs: #17615
    PR-URL: #18800
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  2. test: move getTTYfd() to common helpers

    Fishrock123 committed Feb 16, 2018
    This utility is fairly generic and likely useful for more than one test.
    
    PR-URL: #18800
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Feb 2, 2018
  1. timers: runtime-deprecate {un}enroll()

    Fishrock123 committed Jan 9, 2018
    This was never a Very Good API, and generally just left so many open
    ends for inconsistent behavior. The "optimization" benefit of this API
    is little to none. Makes a starting step towards removing it so that in
    the future timers, especially in their async_hooks interactions, can be
    simplified.
    
    PR-URL: #18066
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Jan 26, 2018
  1. timers: add internal [@@ refresh()] function

    Fishrock123 committed Jan 9, 2018
    Hidden via a symbol because I'm unsure exactly what the API should look
    like in the end.
    
    Removes the need to use _unrefActive for efficiently refreshing
    timeouts.
    It still uses it under the hood but that could be replaced with
    insert() directly if it were in the same file.
    
    PR-URL: #18065
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
  2. timers: reposition getTimers definition internally

    Fishrock123 committed Jan 9, 2018
    Just cleanup so the file makes more future sense.
    
    PR-URL: #18065
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Commits on Jan 11, 2018
  1. http2: fix kUpdateTimer timer refresh

    Fishrock123 committed Jan 9, 2018
    Fixes an oversight from
    93eb68e
    
    Wasn't caught by a test.
    
    PR-URL: #18062
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Dec 28, 2017
  1. http: convert utcDate to use setTimeout

    Fishrock123 authored and BridgeAR committed Dec 21, 2017
    A sort-of follow-up to #17704, this
    removes the last internal use of enroll().
    
    PR-URL: #17800
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Dec 20, 2017
  1. http2: use session kUpdateTimer from kUpdateTimer

    Fishrock123 committed Dec 17, 2017
    Reduces duplicated logic.
    
    PR-URL: #17704
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
  2. http2: use actual Timeout instances

    Fishrock123 committed Dec 17, 2017
    This makes `Http2Stream`s and `Http2Session`s use actual Timeout
    objects in a [kTimeout] symbol property, rather than making the
    stream/session itself a timer and appending properties to it directly.
    
    PR-URL: #17704
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
  3. timers: extract enroll() validation into a fn

    Fishrock123 committed Dec 16, 2017
    This should help keep everything consistent.
    
    PR-URL: #17704
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
  4. net: use actual Timeout instance on Sockets

    Fishrock123 committed Feb 3, 2017
    This makes `net.Sockets` use actual Timeout objects in a `[kTimeout]`
    symbol property, rather than making the socket itself a timer and
    appending properties to it directly.
    
    This should make the code generally easier to understand, and might
    also prevent some deopts from properties being changes on the socket
    itself.
    
    Also moves the Timeout constructor into an internal module.
    
    PR-URL: #17704
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Commits on Dec 18, 2017
  1. doc: not all example code can be run without 1:1

    Fishrock123 committed Dec 15, 2017
    PR-URL: #17702
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
  2. doc: adjust TTY wording & add inter-doc links

    Fishrock123 committed Dec 15, 2017
    PR-URL: #17702
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
  3. doc: fix fs.existsSync description

    Fishrock123 committed Dec 15, 2017
    Also works on directories.
    
    PR-URL: #17702
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
  4. doc: improve documentation.md

    Fishrock123 committed Dec 15, 2017
    Reworded some parts, inter-doc links.
    
    PR-URL: #17702
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Commits on Nov 2, 2017
  1. test: update process-release for Node 8 Carbon

    Fishrock123 committed Nov 1, 2017
    PR-URL: #16656
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Commits on Oct 23, 2017
  1. timers: cleanup extraneous property on Immediates

    Fishrock123 authored and targos committed Dec 9, 2016
    This was originally changed in 6f75b66
    but it appears unnecessary and benhcmark results show little difference
    without the extra property.
    
    Refs: #6436
    PR-URL: #16355
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Oct 12, 2017
  1. doc: rename good first contrib label

    Fishrock123 authored and watilde committed Oct 11, 2017
    Now `good first issue`.
    
    PR-URL: #16150
    Refs: #16149
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Commits on Sep 29, 2017
  1. timers: warn on overflowed timeout duration

    Fishrock123 authored and jasnell committed May 24, 2016
    Cherry-pick from ayo
    
    Ayo commit log:
    > Previously there wasn't any clear indicator when you hit the overflow
    > other than possibly unexpected behavior, and I think emitting a warning
    > may be appropriate.
    
    > PR-URL: ayojs/ayo#71
    > Reviewed-By: Scott Trinh <scott@scotttrinh.com>
    > Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
    > Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    > Reviewed-By: Anna Henningsen <anna@addaleax.net>
    > Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    
    PR-URL: #15627
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Sep 20, 2017
  1. timers: do not expose .unref()._handle._list

    Fishrock123 authored and BridgeAR committed Sep 6, 2016
    The list is defunct at this point.
    I believe this to be in effect a minor defect from
    3eecdf9
    
    PR-URL: #8422
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Julien Gilli <jgilli@nodejs.org>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Aug 26, 2017
  1. test: pipe some error output if npm fails

    Fishrock123 authored and BridgeAR committed Apr 18, 2017
    This test now prints out some child error output if the npm child proc
    fails, allowing us to debug easier.
    
    PR-URL: #12490
    Refs: #12480
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Jul 20, 2017
  1. 2017-07-20, Version 8.2.1 (Current)

    Fishrock123 committed Jul 20, 2017
    Notable changes
    
    * http: Writes no longer abort if the Socket is missing.
    * process, async_hooks: Avoid problems when triggerAsyncId is undefined.
    * zlib: Streams no longer attempt to process data when destroyed.
    
    PR-URL: #14399
Commits on Jul 19, 2017
  1. 2017-07-19, Version 8.2.0 (Current)

    Fishrock123 committed Jul 19, 2017
    Big thanks to @addaleax who prepared the vast majority of this release.
    
    Notable changes:
    
    * **Async Hooks**
      * Multiple improvements to Promise support in `async_hooks` have been made.
    
    * **Build**
      * The compiler version requirement to build Node with GCC has been raised to
        GCC 4.9.4.
        [[`820b011ed6`](820b011)]
        [#13466](#13466)
    
    * **Cluster**
      * Users now have more fine-grained control over the inspector port used by
        individual cluster workers. Previously, cluster workers would simply
        increment from the master's debug port.
        [[`dfc46e262a`](dfc46e2)]
        [#14140](#14140)
    
    * **DNS**
      * The server used for DNS queries can now use a custom port.
        [[`ebe7bb29aa`](ebe7bb2)]
        [#13723](#13723)
      * Support for `dns.resolveAny()` has been added.
        [[`6e30e2558e`](6e30e25)]
        [#13137](#13137)
    
    * **npm**
      * The `npm` CLI has been updated to version 5.3.0. In particular, it now comes
        with the `npx` binary, which is also shipped with Node.
        [[`dc3f6b9ac1`](dc3f6b9)]
        [#14235](#14235)
      * `npm` Changelogs:
          - [v5.0.4](https://github.com/npm/npm/releases/tag/v5.0.4)
          - [v5.1.0](https://github.com/npm/npm/releases/tag/v5.1.0)
          - [v5.2.0](https://github.com/npm/npm/releases/tag/v5.2.0)
          - [v5.3.0](https://github.com/npm/npm/releases/tag/v5.3.0)
    
    PR-URL: #13744
Commits on Apr 26, 2017
  1. deps: remove **/node_modules/form-data/README.md

    Fishrock123 committed Apr 25, 2017
    Having multiple files with the same name but different casings causes
    problems on lots of OS-s.
    
    Refs: #12624
    Refs: #11085
    Refs: #11020
    
    PR-URL: #12643
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Commits on Mar 31, 2017
  1. tty: remove NODE_TTY_UNSAFE_ASYNC

    Fishrock123 authored and addaleax committed Dec 21, 2016
    Nothing but trouble can ever come from it.
    
    PR-URL: #12057
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Older
You can’t perform that action at this time.