Permalink
Switch branches/tags
Commits on Sep 18, 2018
  1. tools: synchronize deepStrictEqual() message rules

    Trott committed Sep 17, 2018
    Update ESLint config to include a rule about assert.deepStrictEqual()
    messages and string literals. The rule is included in lib and test, but
    should be included everywhere else as well.
    
    PR-URL: #22887
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Commits on Sep 17, 2018
  1. tools: prevent string literals in some assertions

    Trott committed Jul 30, 2018
    String literals provided as the third argument to assert.strictEqual()
    or assert.deepStrictEqual() will mask the values that are causing
    issues. Use a lint rule to prevent such usage.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  2. test: prepare test-assert for strictEqual linting

    Trott committed Sep 13, 2018
    Make minor modifications to test-assert.js to prepare it for linting
    rule that forbids the use of string literals for the third argument of
    assert.strictEqual().
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  3. test: remove string literal from assertion

    Trott committed Sep 13, 2018
    Remove string literal as assertion message in call to
    assert.strictEqual() in test-dns-lookup.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  4. test: remove string literal from assertion

    Trott committed Sep 13, 2018
    Remove string literal as assertion message in call to
    assert.strictEqual() in test-dns-resolveany-bad-ancount.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  5. test: remove string literal arg from assertion

    Trott committed Sep 13, 2018
    Remove unnecessary string literal from assert.deepStrictEqual() call.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  6. test: remove string literal message from assertion

    Trott committed Sep 13, 2018
    Remove string literal from assert.strictEqual message to improve output
    of AssertionError.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  7. test: remove string literal from assertion

    Trott committed Sep 13, 2018
    Remove string literal from `assert.strictEqual()` call `message`
    parameter and make it a comment above the assertion instead.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  8. test: refactor flag check

    Trott committed Sep 13, 2018
    Refactor test-vm-run-in-new-context so that check for `--expose-gc` flag
    will not run afoul of an upcoming lint rule that checks that string
    literals are not used for the `message` argument of
    `assert.strictEqual()`.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  9. test: simplify assertion in http2 tests

    Trott committed Sep 2, 2018
    In test-http2-timeout-large-write.js and
    test-http2-timeout-large-write-file.js:
    
    Use assert.ok() on a boolean that the test itself creates and sets,
    rather than assert.strictEqual(). This allows us to use a static message
    without running afoul of the upcoming "do not use string literals with
    assert.strictEqual()" lint rule.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  10. test: improve assertion in test-inspector.js

    Trott committed Sep 2, 2018
    Remove an unecessary string literal from assert.strictEqual() call in
    test-inspector.js. The string literal is printed instead of the value
    that causes an error. Removing the string literal allows the value that
    caused the error to be printed. This improves the troubleshooting
    experience when the test fails due to that assertion.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  11. test: remove string literal message in assertions

    Trott committed Sep 13, 2018
    Remove string literal message in assert.strictEqual() calls in
    test-async-await.js.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  12. test: remove string literal message from assertion

    Trott committed Sep 13, 2018
    Remove string literal message in assert.strictEqual() call in napi test
    testFinalizer.js.
    
    PR-URL: #22849
    Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Sep 16, 2018
  1. tools: update ESLint to 5.6.0

    Trott committed Sep 16, 2018
    Update ESLint to 5.6.0.
    
    PR-URL: #22882
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: George Adams <george.adams@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Commits on Sep 13, 2018
  1. doc: add gabrielschulhof to TSC

    Trott committed Sep 12, 2018
    PR-URL: #22818
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Commits on Sep 6, 2018
  1. tools: update dmn to 2.0.0

    Trott committed Sep 6, 2018
    New version of dmn with better support for case-sensitive file systems.
    Use it in the update-* scripts.
    
    PR-URL: #22733
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
Commits on Sep 5, 2018
  1. doc: add apapirovski to TSC

    Trott committed Sep 5, 2018
    PR-URL: #22717
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Sep 3, 2018
  1. test: fix test-trace-events-dns

    Trott authored and refack committed Sep 3, 2018
    Test is using `common.fileExists()` which has been removed. There is no
    need to check that the file exists as the attempt to read the file in
    the next line will fail if the file does not exist. Remove existence
    check.
    
    PR-URL: #22674
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Sep 2, 2018
  1. doc: indicate createSecureContext arg is optional

    Trott authored and addaleax committed Aug 27, 2018
    The `options` argument to `tls.createSecureContext()` is optional.
    
    Indicate this by using `[` and `]` in the function signature.
    
    PR-URL: #22545
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: George Adams <george.adams@uk.ibm.com>
  2. doc: remove _optional_ designation for tls options

    Trott authored and addaleax committed Aug 27, 2018
    Options are, by definition, optional. Remove specification of some
    options as "optional".
    
    PR-URL: #22545
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: George Adams <george.adams@uk.ibm.com>
Commits on Aug 31, 2018
  1. tools: specify rule disabled in test-assert.js

    Trott authored and addaleax committed Aug 28, 2018
    Instead of disabling all ESLint rules on two lines in test-assert.js,
    specify the rule that needs to be disabled.
    
    PR-URL: #22563
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  2. tools: specify rules disabled in common/dns.js

    Trott authored and addaleax committed Aug 28, 2018
    Instead of disabling all ESLint rules for a line, specify the two rules
    that should be disabled.
    
    PR-URL: #22563
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  3. test: remove skip of OS X bug

    Trott committed Aug 27, 2018
    Three tests are skipped because of Applie bug 17894467. That bug exists
    in OS X 10.10, but we no longer support 10.10 (and neither does Apple).
    Remove the test-skipping.
    
    PR-URL: #22546
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Aug 30, 2018
  1. test: fix typo in test name

    Trott committed Aug 30, 2018
    Correct test name to reflect the module it tests (`trace_events`).
    
    PR-URL: #22605
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  2. doc: make Stability Index more concise

    Trott authored and gdams committed Aug 27, 2018
    Shorten the Stability Index text.
    
    PR-URL: #22544
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Aug 27, 2018
  1. doc: simplify http2 wording and formatting

    Trott committed Aug 26, 2018
    Remove `It is important to note that` and italics from `waitForTrailers`
    sentences.
    
    PR-URL: #22541
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  2. doc: clarify ERR_AMBIGUOUS_ARGUMENT

    Trott committed Aug 27, 2018
    PR-URL: #22542
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Aug 24, 2018
  1. tools: update ESLint to 5.4.0

    Trott committed Aug 22, 2018
    Update ESLint from 5.3.0 to 5.4.0.
    
    PR-URL: #22454
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
Commits on Aug 21, 2018
  1. test: improve assert message in http timeout test

    Trott committed Aug 19, 2018
    PR-URL: #22403
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  2. test: move http timeout test to parallel

    Trott committed Aug 19, 2018
    test-http-client-timeout-option-with-agent no longer checks that the
    timeout happens within a certain tolerance so it can be moved to the
    parallel test suite.
    
    PR-URL: #22403
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  3. test: fix flaky http timeout test

    Trott committed Aug 19, 2018
    There is no guarantee that a timeout won't be delayed considerably due
    to unrelated activity on the host. Instead of checking that the timeout
    happens within a certain tolerance, simply check that it did not happen
    too soon.
    
    Fixes: #22041
    
    PR-URL: #22403
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Aug 19, 2018
  1. tools: simplify ESLint invocation in Makefile

    Trott committed Aug 16, 2018
    Makefile currently enforces .eslintrc.js linting on the command line but
    it is already enforced in the .estlintignore file.
    
    This also simplifies an arguably-related comment in .estlinrc.js.
    
    PR-URL: #22348
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Commits on Aug 14, 2018
  1. doc: simplify urlObject.hash text

    Trott committed Aug 14, 2018
    Remove "consists of" in favor of "is". Use "fragment identifier" instead
    of "fragment" and remove quotes.
    
    PR-URL: #22326
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
  2. doc: simplify urlObject.hash description

    Trott committed Aug 14, 2018
    It's an octothorp, but no one knows what that is either so let's just
    show the character in the sentence and be done with it.
    
    PR-URL: #22326
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Bryan English <bryan@bryanenglish.com>
  3. doc: simplify format description of urlObject.auth

    Trott committed Aug 14, 2018
    The "at sign" is properly the "commercial at" but let's just avoid the
    whole naming issue by putting the symbol right in the sentence.
    
    PR-URL: #22324
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Bryan English <bryan@bryanenglish.com>