Skip to content
Permalink
Branch: master
Commits on Nov 21, 2017
  1. src: remove unprofessional slang in assertions

    aqrln authored and jasnell committed Nov 21, 2017
    Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable
    `UNREACHABLE()` macro invocations in `node_zlib.cc`.
    
    PR-URL: #17166
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Commits on Aug 29, 2017
  1. build: fix indentation in node.gyp

    aqrln authored and jasnell committed Aug 27, 2017
    One line in node.gyp was indented using a mix of a tab and spaces,
    convert it to all spaces.
    
    PR-URL: #15051
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jul 24, 2017
  1. repl: improve require() autocompletion

    aqrln committed Jul 21, 2017
    Currently REPL supports autocompletion for core modules and those found
    in node_modules.  This commit adds tab completion for modules relative
    to the current directory.
    
    PR-URL: #14409
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jul 22, 2017
  1. test: move timing-dependent tests to sequential

    aqrln committed Jul 19, 2017
    Move test-http-server-keep-alive-timeout-slow-server and
    test-http-server-keep-alive-timeout-slow-client-headers from parallel to
    sequential to resolve test flakiness on freebsd10-64.
    
    Fixes: #14033
    Refs: #9317
    PR-URL: #14377
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Commits on Jul 3, 2017
  1. test: refactor test-http(s)-set-timeout-server

    aqrln authored and refack committed Jun 26, 2017
    * Make changes to `test-https-set-timeout-server` to resolve
      inconsistencies with its http counterpart:
    
      - Apply the changes analogous to those in GH-13802 to the https test.
      - Add a missing `common.mustCall()` wrapper.
      - Make small stylistic changes (e.g., remove unnecessary line breaks
        in comments) to make it visually consistent with the http test.
    
    * Use arrow functions.
    
    PR-URL: #13935
    Fixes: #13588
    Refs: #13802
    Refs: #13625
    Refs: #13822
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jun 13, 2017
  1. http: fix timeout reset after keep-alive timeout

    aqrln committed Jun 8, 2017
    Fix the logic of resetting the socket timeout of keep-alive HTTP
    connections and add two tests:
    
    * `test-http-server-keep-alive-timeout-slow-server` is a regression test
      for GH-13391.  It ensures that the server-side keep-alive timeout will
      not fire during processing of a request.
    
    * `test-http-server-keep-alive-timeout-slow-client-headers` ensures that
      the regular socket timeout is restored as soon as a client starts
      sending a new request, not as soon as the whole message is received,
      so that the keep-alive timeout will not fire while, e.g., the client
      is sending large cookies.
    
    Refs: #2534
    Fixes: #13391
    PR-URL: #13549
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
Commits on May 25, 2017
  1. doc: make the style of notes consistent

    aqrln authored and refack committed May 20, 2017
    Make the style of "Note:" paragraphs consistent and document the
    guidelines in `doc/STYLE_GUIDE.md`.
    
    PR-URL: #13133
    Fixes: #13131
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Commits on May 23, 2017
  1. doc: improve formatting of STYLE_GUIDE.md

    aqrln authored and addaleax committed May 20, 2017
    * Wrap text at 80 characters.
    * Use periods consistently.
    
    PR-URL: #13135
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <mhdawson@ibm.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
  2. doc: fix incorrect keyboard shortcut

    aqrln authored and addaleax committed May 20, 2017
    This commit fixes an incorrect keyboard shortcut in
    `doc/STYLE_GUIDE.md`: entering em-dashes is done via Alt+Shift+"-" on
    macOS, not via Ctrl+Alt+"-". Besides that, Option is more canonical name
    of Alt on Macs.
    
    PR-URL: #13134
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <mhdawson@ibm.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Commits on May 21, 2017
  1. zlib: fix node crashing on invalid options

    aqrln committed May 18, 2017
    This commit fixes the Node process crashing when constructors of classes
    of the zlib module are given invalid options.
    
    * Throw an Error when the zlib library rejects the value of windowBits,
      instead of crashing with an assertion.
    
    * Treat windowBits and memLevel options consistently with other ones and
      don't crash when non-numeric values are given.
    
    * Fix bugs in the validation logic:
      - Don't conflate 0 and undefined when checking if a field of an
        options object exists.
      - Treat NaN and Infinity values the same way as values of invalid
        types instead of allowing to actually set zlib options to NaN or
        Infinity.
    
    PR-URL: #13098
    Fixes: #13082
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Commits on Apr 29, 2017
  1. doc: fixup the collaborators list

    aqrln committed Apr 29, 2017
    * Add the personal pronoun for @aqrln.
    * Fix incorrectly ordered @lucamaraschi entry.
    
    PR-URL: #12750
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Commits on Apr 8, 2017
  1. test: add basic cctest for base64.h

    aqrln committed Apr 5, 2017
    This commit adds C++ tests for `base64_encode()` and `base64_decode()`
    functions defined in `base64.h`.  The functionality is already being
    tested indirectly in JavaScript tests for Buffer, but it won't hurt to
    test the low-level functions too, especially given that they aren't only
    used in the internal Buffer implementation, Chrome inspector protocol
    support relies upon them too.
    
    PR-URL: #12238
    Refs: #12146 (comment)
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Commits on Apr 7, 2017
  1. doc: add aqrln to collaborators

    aqrln committed Apr 7, 2017
    Add Alexey Orlenko (@aqrln) to the list of collaborators in README.md
    
    PR-URL: #12273
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Apr 4, 2017
  1. test: add Unicode characters regression test

    aqrln authored and jasnell committed Feb 16, 2017
    This test ensures that UTF-8 characters can be used in core JavaScript
    modules built into Node's binary.
    
    PR-URL: #11423
    Ref: #11129
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  2. buffer: optimize decoding wrapped base64 data

    aqrln authored and jasnell committed Mar 31, 2017
    The fast base64 decoder used to switch to the slow one permanently when
    it saw a whitespace or other garbage character.  Since the most common
    situation such characters may be encountered in is line-wrapped base64
    data, a more profitable strategy is to decode a single 24-bit group with
    the slow decoder and then continue running the fast algorithm.
    
    PR-URL: #12146
    Ref: #12114
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 27, 2017
  1. test: fix broken tests in test-buffer-includes

    aqrln authored and jasnell committed Mar 25, 2017
    Some of the tests for `buffer.includes()` functionality introduced in
    #3567 have been broken in a way that
    caused them to always pass regardless of the result of the tested
    method.
    
    This behavior was caused by two reasons:
    
     * These tests were written as though `buffer.includes()` was supposed
       to return the same value that `buffer.indexOf()` does, i.e., used
       indices or -1 as expected return values instead of true and false.
     * `assert()` was used as the assertion function to do that instead of
       `assert.strictEqual()`.
    
    Thus `assert()` was called with a non-zero number as the first argument
    effectively causing these tests to pass.
    
    This commit changes the tests to use `assert.ok()` and removes redundant
    indices.
    
    PR-URL: #12040
    Ref: #3567
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 15, 2017
  1. test: refactor test-util-inspect.js

    aqrln authored and jasnell committed Mar 10, 2017
    * Enclose tests that used to introduce module-level variables into
      their own scopes.
    * Replace ES5 anonymous functions with arrow functions where it makes
      sense.
    * And make one arrow function a regular function thus fixing a bug in a
      getter inside an object created in "Array with dynamic properties"
      test.  This getter has never been invoked though, so the test hasn't been
      failing.
    * Convert snake_case identifiers to camelCase.
    * Make some variable names more readable.
    * Replace regular expressions in maxArrayLength tests with simple
      assert.strictEquals() and assert(...endsWith()) checks, as suggested
      in <#11576 (comment)>.
    
    PR-URL: #11779
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  2. test: add arrow functions to test-util-inspect

    aqrln authored and jasnell committed Mar 10, 2017
    Even though arrow functions and ES5 anonymous functions are technically
    the same for util.js, it won't hurt to test both.  The same goes for
    async functions.
    
    PR-URL: #11781
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
  3. test: fix repl-function-redefinition-edge-case

    aqrln authored and jasnell committed Mar 8, 2017
    `test/known_issues/test-repl-function-redefinition-edge-case.js` had
    been introduced as a part of #7624
    but the meat of the test became fixed in
    007386e. Despite that, the test
    continued to fail since it was broken itself: there was a missing colon
    in the expected output.
    
    This commit adds the missing colon and moves the test from
    `test/known_issues` to `test/parallel`.
    
    PR-URL: #11772
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Mar 14, 2017
  1. doc: fix stylistic issues in api/net.md

    aqrln authored and joyeecheung committed Mar 10, 2017
    * Change var to const in an example of server creation.
    * Add missing semicolons.
    * Use `console` syntax highlighting in `telnet` and `nc` invocation
      examples and add shell prompt symbols to be consistent with the rest
      of the documentation.
    
    PR-URL: #11786
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 10, 2017
  1. util: change sparse arrays inspection format

    aqrln authored and addaleax committed Feb 27, 2017
    Missing elements in sparse arrays used to be serialized to empty
    placeholders delimited with commas by util.inspect() and in some cases
    the result was a syntactically correct representation of a JavaScript
    array with shorter length than the original one. This commit implements
    @TimothyGu's suggestion to change the way util.inspect() formats sparse
    arrays to something similar to how Firefox shows them.
    
    Fixes: #11570
    PR-URL: #11576
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Jan 23, 2017
  1. src: add a missing space in node_os.cc

    aqrln authored and jasnell committed Jan 21, 2017
    This commit makes a small stylistic fix adding a missing space in
    GetOSType function in node_os.cc
    
    PR-URL: #10931
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michal Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jan 12, 2017
  1. src: enable writev for pipe handles on Unix

    aqrln authored and jasnell committed Jan 7, 2017
    This commit enables writev for Unix Domain Sockets on supported
    platforms thus enabling cork/uncork functionality for them and
    improving IPC performance.
    
    Fixes: #5095
    PR-URL: #10677
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jan 11, 2017
  1. doc: fix misleading language in vm docs

    aqrln authored and mscdex committed Jan 9, 2017
    The note following the http.Server example in the vm documentation
    contains misleading language. This commit removes the incorrect
    reference to threads.
    
    Fixes: #10697
    PR-URL: #10708
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
You can’t perform that action at this time.