Permalink
Switch branches/tags
Commits on Sep 15, 2018
  1. doc: add withFileTypes option to fsPromises.readdir

    bengl authored and trivikr committed Sep 13, 2018
    PR-URL: #22833
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Commits on Aug 22, 2018
  1. test: remove redundant cli tests

    bengl committed Aug 16, 2018
    test/parallel/test-cli-eval.js covers them, and many more things.
    
    PR-URL: #22355
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: George Adams <george.adams@uk.ibm.com>
Commits on Aug 14, 2018
  1. fs: readdir optionally returning type information

    bengl committed Jul 28, 2018
    readdir and readdirSync now have a "withFileTypes" option, which, when
    enabled, provides an array of DirectoryEntry objects, similar to Stats
    objects, which have the filename and the type information.
    
    Refs: #15699
    
    PR-URL: #22020
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Roman Reiss <me@silverwind.io>
    Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Commits on May 7, 2018
  1. constants: freeze the constants object

    bengl authored and BridgeAR committed Apr 4, 2018
    Constants ought to be constant. The primary goal of this commit is to
    make constants exposed in require('constants') immutable, as they were
    prior to node@7.0.0, and as the constants exposed on fs.constants,
    crypto.constants, etc. are.
    
    Since this is implemented by using Object.freeze, it also has the side
    effect of making the entire exports of require('constants') immutable,
    so no new constants can be defined on the object in userland.
    
    PR-URL: #19813
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Commits on Feb 1, 2018
  1. test: fix flaky test-http-dns-error

    bengl authored and BridgeAR committed Oct 26, 2017
    Under some conditions, the error received from getaddrinfo might
    actually be EAGAIN, meaning the request should be retried. Allowing for
    5 retries before erroring out.
    
    Also replace one-off function with common.mustNotCall().
    
    PR-URL: #16534
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Nov 5, 2017
  1. http: use arrow fns for lexical `this` in Agent

    bengl committed Oct 25, 2017
    PR-URL: #16475
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Oct 26, 2017
  1. https: refactor to use http internals

    bengl committed Oct 23, 2017
    Rather than using `http`, use `_http_client`, etc. directly.
    
    Also moving all the exports to the bottom, in line with most of the rest
    of the codebase.
    
    PR-URL: #16395
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Oct 25, 2017
  1. buffer: move setupBufferJS to internal

    bengl authored and jasnell committed Oct 22, 2017
    Stashing it away in internal/buffer so that it can't be used in
    userland, but can still be used in internals.
    
    PR-URL: #16391
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Oct 22, 2017
  1. tty,doc: add type-check to isatty

    bengl committed Sep 23, 2017
    Previously, various inputs other than non-negative integers would
    produce incorrect results.
    
    Added type-checking on input, returning false for anything other than
    non-negative integers.
    
    Also clarified in docs.
    
    PR-URL: #15567
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Commits on Oct 18, 2017
  1. fs: remove no-longer-relevant comment

    bengl authored and jasnell committed Oct 18, 2017
    The comment suggests that the subsequent code could by DRYed up, due to
    simply passing arguments along. However, in the commits since then, this
    no longer appears to apply, and so the comment is now confusing with
    respect to the current code.
    
    PR-URL: #16285
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Oct 1, 2017
  1. tty: require readline at top of file

    bengl authored and BridgeAR committed Sep 28, 2017
    No need to require it on each of those function calls.
    
    PR-URL: #15647
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
  2. test: fix flaky test-crypto-classes.js

    bengl authored and jasnell committed Sep 28, 2017
    On non-FIPS, we can instantiate DiffieHellman with 256 instead of 1024.
    This should be quite a bit faster, and therefore prevent the timeouts.
    
    PR-URL: #15662
    Fixes: #15655
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Sep 28, 2017
  1. http: client keep-alive for UNIX domain sockets

    bengl committed May 25, 2017
    Makes `Connection: keep-alive` behave correctly when making client
    connections to UNIX domain sockets.
    
    Prior to this, connections would never be re-used, but the keep-alive
    would cause the connections to stick around until they time out. This
    would lead to an eventual EMFILE error due to all the connections
    staying open. This was due to http.Agent not properly supporting UNIX
    domain sockets.
    
    PR-URL: #13214
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Sep 27, 2017
  1. crypto: expose ECDH class

    bengl committed Aug 19, 2016
    For consistency with the rest of the crypto classes, exposes the ECDH
    class. Originally, only the createECDH function was exposed, and there
    was no real reason to hide the class.
    
    PR-URL: #8188
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  2. test: crypto createClass instanceof Class

    bengl committed Aug 19, 2016
    The crypto classes are also exposed as createClass for each class. This
    tests that each of them returns an instance of the class in question.
    
    PR-URL: #8188
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Sep 26, 2017
  1. doc: ctc -> tsc in onboarding extras

    bengl authored and lpinca committed Sep 26, 2017
    PR-URL: #15621
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Khaidi Chu <i@2333.moe>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Sep 25, 2017
  1. doc: ctc -> tsc in collab guide

    bengl committed Sep 24, 2017
    PR-URL: #15590
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Sep 22, 2017
  1. tls: prefer path over port in connect

    bengl committed Aug 1, 2017
    Makes tls.connect() behave as documented, preferring options.path over
    options.port. This makes it consistent with net.connect(), so the
    included test demonstrates that both behave in this way.
    
    Also, for consistency, noting the precedence of options.path in net
    doc.
    
    PR-URL: #14564
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Mar 24, 2017
  1. process: maintain constructor descriptor

    bengl authored and addaleax committed Oct 26, 2016
    Use the original property descriptor instead of just taking the value,
    which would, by default, be non-writable and non-configurable.
    
    PR-URL: #9306
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
Commits on Nov 29, 2016
  1. constants: errors -> errno

    bengl authored and italoacasas committed Oct 28, 2016
    lib/constants.js was incorrectly copying the constants from the
    binding, by copying from `contants.os.errors` instead of
    `constants.os.errno`.
    
    PR-URL: #9349
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
    Reviewed-By: Ron Korving <ron@ronkorving.nl>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Oct 3, 2016
  1. module: fix comment from "read-only" to "shallow"

    bengl authored and fhinkel committed Oct 1, 2016
    The comment here was misleading, implying that the property was being
    copied as a read-only, when in fact it's just a shallow copy. This
    serves the purpose of providing the array for introspection, but it
    isn't read-only.
    
    PR-URL: #8887
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Commits on Sep 20, 2016
  1. util: don't init Debug if it's not needed yet

    bengl authored and jasnell committed Sep 8, 2016
    Because any call to util.inspect() with an object results in
    inspectPromise() being called, Debug was being initialized even when
    it's not needed. Instead, the initialization is placed after the
    isPromise check.
    
    PR-URL: #8452
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
Commits on Aug 18, 2016
  1. util: fix deprecated class prototype

    bengl authored and jasnell committed Aug 14, 2016
    Ensure the wrapped class prototype is exactly the unwrapped class
    prototype, rather than an object whose prototype is the unwrapped
    class prototype.
    
    This ensures that instances of the unwrapped class are instances
    of the wrapped class. This is useful when both a wrapped class and
    a factory for the unwrapped class are both exposed.
    
    Ref: #8103
    PR-URL: #8105
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Aug 5, 2016
  1. doc: clarify "Reviewed-By" iff "LGTM"

    bengl authored and jasnell committed Jun 6, 2016
    As per conversation with @Trott, make it clear that Reviewed-By lines
    should only be added for collaborators who've actually put a LGTM on the
    PR.
    
    PR-URL: #7183
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: JacksonTian - Jackson Tian <shvyo1987@gmail.com>
Commits on Jun 6, 2016
  1. test: use common.fixturesDir almost everywhere

    bengl committed May 26, 2016
    Updating tests to use `common.fixturesDir` whenever possible/reasonable.
    Left out things like tests for `path` and `require.resolve`.
    
    PR-URL: #6997
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on May 21, 2016
  1. doc: add bengl to collaborators

    bengl committed May 21, 2016
    PR-URL: #6921
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Commits on May 9, 2016
  1. doc: v8 functions as methods on v8

    bengl authored and targos committed May 6, 2016
    For consistency with other docs, show v8 functions as being on the v8
    object.
    
    PR-URL: #6615
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
  2. doc: add `added:` information for os

    bengl authored and addaleax committed May 6, 2016
    Via git spelunking, mostly.
    Some functions have been renamed. Used the version in which they were
    renamed.
    
    Ref: #6578
    PR-URL: #6609
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
  3. doc: add `added:` information for process

    bengl authored and addaleax committed May 5, 2016
    Most of the information is gleaned from changelogs. The rest is inferred
    from git history.
    
    Omitted cpuUsage() since it's not yet in a release.
    
    Also omitted the streams, events and signals, since I didn't really
    think it made sense for those.
    
    Ref: #6578
    PR-URL: #6589
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
  4. doc: add `added:` information for url

    bengl authored and addaleax committed May 5, 2016
    Module introduced in 7ff04c1.
    
    Ref: #6578
    PR-URL: #6593
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  5. doc: add `added:` information for querystring

    bengl authored and addaleax committed May 5, 2016
    Module introduced in 7ff04c1.
    
    Ref: #6578
    PR-URL: #6593
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on May 6, 2016
  1. test: add tests for console.[info|error|warn]

    bengl authored and evanlucas committed May 2, 2016
    Just copied the basic tests for log, as they're all the same thing
    as log in either stdout or stderr. Cleaned that up a bit.
    
    Also const-ified.
    
    PR-URL: #6538
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Apr 27, 2016
  1. http: correct error message for invalid trailer

    bengl authored and jasnell committed Apr 20, 2016
    Prevent misleading error messages when trailers are invalid.
    
    PR-URL: #6308
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Brian White <mscdex@mscdex.net>
Commits on Apr 18, 2016
  1. doc: native module reloading is not supported

    bengl authored and jasnell committed Apr 12, 2016
    Clarify in docs for require.cache that reloading native modules
    isn't supported.
    
    Related: #6160
    PR-URL: #6168
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Apr 2, 2016
  1. doc: consolidate timers docs in timers.markdown

    bengl authored and claudiorodriguez committed Mar 21, 2016
    Rather than attempting to keep two versions of docs for timers up to
    date, keep them in timers.markdown, and leave references to them in
    globals.markdown.
    
    Add setImmediate and clearImmediate to globals.markdown.
    
    Change "To schedule" to "Schedules" in timers.markdown.
    
    PR-URL: #5837
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>