Skip to content
Permalink
Branch: master
Commits on Jul 14, 2019
  1. build: remove broken intel vtune support

    bnoordhuis authored and addaleax committed Jul 3, 2019
    Support for VTune profiling was added in commit a881b53 from November
    2015 but has since bitrotted. Remove it.
    
    Fixes: #28310
    Refs: #3785
    
    PR-URL: #28522
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  2. test: fix pty test hangs on aix

    bnoordhuis authored and addaleax committed Jul 8, 2019
    Some pty tests persistently hung on the AIX CI buildbots. Fix that by
    adding a helper script that properly sets up the pty before spawning
    the script under test.
    
    On investigation I discovered that the test runner hung when it tried
    to close the slave pty's file descriptor, probably due to a bug in
    AIX's pty implementation. I could reproduce it with a short C program.
    The test runner also leaked file descriptors to the child process.
    
    I couldn't convince python's `subprocess.Popen()` to do what I wanted
    it to do so I opted to move the logic to a helper script that can do
    fork/setsid/etc. without having to worry about stomping on state in
    tools/test.py.
    
    In the process I also uncovered some bugs in the pty module of the
    python distro that ships with macOS 10.14, leading me to reimplement
    a sizable chunk of the functionality of that module.
    
    And last but not least, of course there are differences between ptys
    on different platforms and the helper script has to paper over that.
    Of course.
    
    Really, this commit took me longer to put together than I care to admit.
    
    Caveat emptor: this commit takes the hacky ^D feeding to the slave out
    of tools/test.py and puts it in the *.in input files. You can also feed
    other control characters to tests, like ^C or ^Z, simply by inserting
    them into the corresponding input file. I think that's nice.
    
    Fixes: nodejs/build#1820
    Fixes: #28489
    
    PR-URL: #28600
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Jul 6, 2019
  1. src: block SIGTTOU before calling tcsetattr()

    bnoordhuis authored and addaleax committed Jul 4, 2019
    We might be a background job that doesn't own the TTY so block SIGTTOU
    before making the tcsetattr() call, otherwise that signal suspends us.
    
    This is a better fix than PR #28490 for issue #28479.
    
    Fixes: #28530
    Fixes: #28479
    Refs: #28490
    
    PR-URL: #28535
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Commits on Jul 5, 2019
  1. test: don't use deprecated crypto.fips property

    bnoordhuis authored and danbev committed Jul 2, 2019
    `crypto.fips` was deprecated in commit 6e7992e ("crypto: docs-only
    deprecate crypto.fips, replace") but its usage in `common.hasFipsCrypto`
    seems to have been overlooked.
    
    PR-URL: #28509
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Jul 2, 2019
  1. src: don't abort on EIO when restoring tty

    bnoordhuis authored and devsnek committed Jul 1, 2019
    EIO has been observed to be returned by the Linux kernel under some
    circumstances. Reading through drivers/tty/tty_io*.c, it seems to
    indicate the tty went away. Of course none of this is documented.
    
    Fixes: #28479
    
    PR-URL: #28490
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Gus Caplan <me@gus.host>
Commits on Jun 25, 2019
  1. test: set LC_ALL to known good value

    bnoordhuis authored and Trott committed Jun 6, 2019
    Set the locale to a known good value because it affects ICU's date
    string formatting. Setting LC_ALL needs to happen before the first
    call to `icu::Locale::getDefault()` because ICU caches the result.
    
    Fixes: #27856
    
    PR-URL: #28096
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Commits on Jun 14, 2019
  1. build: unbreak --with-intl=system-icu build

    bnoordhuis authored and Trott committed Jun 7, 2019
    Include directories are configured by the tools/icu/icu-*.gyp files.
    The v8.gyp file doesn't need to add them and in fact the way it did
    that breaks when building against an external copy of ICU.
    
    Fixes: #28052
    PR-URL: #28118
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  2. build: fix icu-i18n pkg-config version check

    bnoordhuis authored and Trott committed Jun 7, 2019
    The pkg_config() helper can either return a tuple of None values
    (no pkg-config installed) and that was what the check was testing
    for, but it can also return a tuple of empty strings when the
    package isn't installed.
    
    PR-URL: #28118
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  3. build: don't swallow pkg-config warnings

    bnoordhuis authored and Trott committed Jun 7, 2019
    PR-URL: #28118
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jun 13, 2019
  1. src: restore stdio on program exit

    bnoordhuis authored and Trott committed May 24, 2019
    Record the state of the stdio file descriptors on start-up and restore
    them to that state on exit.  This should prevent issues where node.js
    sometimes leaves stdio in raw or non-blocking mode.
    
    This is a reworked version of commit c2c9c0c from May 2018 that was
    reverted in commit 14dc17d from June 2018. The revert was a little
    light on details but I infer that the problem was caused by a missing
    call to `uv_tty_reset_mode()`.
    
    Apropos the NOLINT comments: cpplint doesn't understand do/while
    statements, it thinks they're while statements without a body.
    
    Fixes: #14752
    Fixes: #21020
    Original-PR-URL: #20592
    
    PR-URL: #24260
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Jun 4, 2019
  1. test: more tls hostname verification coverage

    bnoordhuis authored and danbev committed Jun 1, 2019
    Add some additional tests that check the interaction of an IP address
    as the Common Name and the presence (or lack of presence) of DNS, URI,
    and IP Address Subject Alternative Names.
    
    PR-URL: #27999
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Commits on Jun 2, 2019
  1. inspector: more conservative minimum stack size

    bnoordhuis authored and Trott committed May 24, 2019
    PTHREAD_STACK_MIN is 2 KB with musl, which is too small to safely
    receive signals. PTHREAD_STACK_MIN + MINSIGSTKSZ is 8 KB on arm64,
    which is the musl architecture with the biggest MINSIGSTKSZ so let's
    use that as a lower bound and let's quadruple it just in case.
    
    PR-URL: #27855
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on May 24, 2019
  1. n-api: DRY napi_coerce_to_x() API methods

    bnoordhuis authored and danbev committed May 21, 2019
    PR-URL: #27796
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on May 23, 2019
  1. src: make process.env.TZ setter clear tz cache

    bnoordhuis committed May 23, 2019
    Since the presence of the libc and V8 timezone caches seem to be
    a perennial source of confusion to users ("why doesn't it work?!"),
    let's try to support that pattern by intercepting assignments to
    the TZ environment variable and reset the caches as a side effect.
    
    Fixes: #19974
    PR-URL: #20026
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
  2. src: ignore SIGXFSZ, don't terminate (ulimit -f)

    bnoordhuis committed May 23, 2019
    Ignore SIGXFSZ signals so that exceeding RLIMIT_FSIZE makes the
    offending system call fail with EFBIG instead of terminating the
    process.
    
    PR-URL: #27798
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  3. deps: histogram: unexport symbols

    bnoordhuis committed May 23, 2019
    Fixes: nodejs/node-gyp#1755
    Fixes: #27778
    PR-URL: #27779
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  4. src: remove freebsd SA_RESETHAND workaround

    bnoordhuis committed May 23, 2019
    This workaround should no longer be necessary with supported versions
    of FreeSBD.
    
    Originally introduced in commit b64983d ("src: reset signal handler
    to SIG_DFL on FreeBSD") from March 2015.
    
    Fixes: #27515
    PR-URL: #27780
    Refs: #27246 (comment)
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on May 20, 2019
  1. tls: expose built-in root certificates

    bnoordhuis committed May 20, 2019
    Fixes: #25824
    PR-URL: #26415
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ron Korving <ron@ronkorving.nl>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Commits on May 6, 2019
  1. tools: fix node-core/required-modules eslint rule

    bnoordhuis authored and danbev committed May 2, 2019
    Make the node-core/required-modules eslint rule smart enough
    to recognize that `import '../common/index.mjs'` in ESM files
    imports the mandatory 'common' module.
    
    PR-URL: #27545
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Apr 24, 2019
  1. tools: fix use-after-free mkcodecache warning

    bnoordhuis authored and danbev committed Apr 21, 2019
    Call `v8::Platform::ShutdownPlatform()` to fix a Coverity warning about
    the `v8::Platform` instance being deleted when it's still in use.
    
    PR-URL: #27332
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Apr 15, 2019
  1. test: test privateEncrypt/publicDecrypt + padding

    bnoordhuis authored and danbev committed Apr 11, 2019
    Verify that RSA_NO_PADDING and RSA_PKCS1_PADDING work as advertised.
    
    PR-URL: #27188
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Commits on Apr 5, 2019
  1. test: test vm.runInNewContext() filename option

    bnoordhuis authored and danbev committed Apr 2, 2019
    The 'filename as a string' case was already being tested. This commit
    also exercises the 'filename as an option' case.
    
    PR-URL: #27056
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Gus Caplan <me@gus.host>
Commits on Apr 4, 2019
  1. build: fix inspector dependency resolution

    bnoordhuis authored and BridgeAR committed Mar 31, 2019
    It was reported that parallel builds on Windows sometimes error because
    of missing intermediate files.
    
    On closer inspection I noticed that some files are copied from src/ to
    the intermediate build directory in a way where they don't participate
    in dependency resolution. Put another way, the build system doesn't
    know to wait for the copy to complete because we don't tell it to.
    
    Fix that by not copying around files but instead making the script that
    processes them a little smarter about where to find them and where to
    store the results.
    
    PR-URL: #27026
    Fixes: #27025
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  2. src: move AsyncResource impl out of public header

    bnoordhuis authored and BridgeAR committed Mar 22, 2019
    Implementing the methods out-of-line (i.e., not inline) means we can fix
    bugs and have already compiled add-ons pick up the fixes automatically,
    something that doesn't work when the methods are inline because then
    they get compiled into the add-on instead of the node binary.
    
    PR-URL: #26348
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  3. src: use sizeof(var) instead of sizeof(type)

    bnoordhuis authored and danbev committed Apr 1, 2019
    Change `memset(&s, 0, sizeof(type))` to `memset(&s, 0, sizeof(s))`.
    The former is dangerous when the type of `s` changes.
    
    PR-URL: #27038
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Commits on Apr 3, 2019
  1. src: check return value, silence coverity warning

    bnoordhuis authored and danbev committed Mar 29, 2019
    PR-URL: #26997
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Commits on Mar 30, 2019
  1. build: remove unused label from vcbuild.bat

    bnoordhuis authored and targos committed Mar 25, 2019
    Remove the :wix-not-found label and harmonize the spelling of "WiX".
    
    PR-URL: #26901
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Commits on Mar 25, 2019
  1. src: micro-optimize ALPN negotiation

    bnoordhuis authored and Trott committed Mar 21, 2019
    99 out of a 100 times (conservative estimate!) the negotiated protocol
    will be either "h2" or "http/1.1" so reuse an existing JS string for
    those instead of creating a new one every time.
    
    PR-URL: #26836
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Mar 18, 2019
  1. src: use EVPKeyPointer in more places

    bnoordhuis authored and danbev committed Mar 13, 2019
    Rejoice, the code base is now free of manual EVP_PKEY_free() calls!
    
    PR-URL: #26632
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 4, 2019
  1. inspector: print all listening addresses

    bnoordhuis authored and BridgeAR committed Feb 8, 2019
    Some hostnames have multiple interfaces. Before this commit, the
    inspector only printed the first one. Now, it prints them all.
    
    No test. I can't think of a reliable way to test this on the CI matrix.
    
    PR-URL: #26008
    Fixes: #13772
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 2, 2019
  1. build: make 'floating patch' message informational

    bnoordhuis authored and addaleax committed Feb 28, 2019
    Downgrade the 'Using floating patch' message that is emitted
    when a local patch is applied to the bundled ICU from a warning
    to a notice. There isn't anything the user can or should do so
    warning isn't appropriate. Instead of angry yellow use soothing green.
    
    Fixes: #26346
    
    PR-URL: #26349
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Feb 22, 2019
  1. build: remove mips support

    bnoordhuis authored and danbev committed Feb 18, 2019
    Upstream V8 is dropping support for mips/mipsel/mips64/mips64el.
    This commit removes the build flags from the configure script
    and some loose ends from the documentation.
    
    PR-URL: #26192
    Fixes: #26179
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Yang Guo <yangguo@chromium.org>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Feb 21, 2019
  1. src: move function from header to source file

    bnoordhuis authored and danbev committed Feb 17, 2019
    This particular Buffer::New() overload used to live in node_internals.h
    to work around a cyclic header dependency (IIRC) but that is no longer
    necessary.
    
    PR-URL: #26173
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  2. crypto: make ConvertKey clear openssl error stack

    bnoordhuis authored and danbev committed Feb 16, 2019
    Failed ConvertKey() operations should not leave errors on OpenSSL's
    error stack because that's observable by subsequent cryptographic
    operations. More to the point, it makes said operations fail with
    an unrelated error.
    
    PR-URL: #26153
    Fixes: #26133
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jan 28, 2019
  1. dns: use IDNA 2008 to encode non-ascii hostnames

    bnoordhuis authored and addaleax committed Oct 10, 2018
    Before this commit, Node.js left it up to the system resolver or c-ares.
    
    Leaving it to the system resolver introduces platform differences
    because:
    
    * some support IDNA 2008
    * some only IDNA 2003 (glibc until 2.28), and
    * some don't support IDNA at all (musl libc)
    
    c-ares doesn't support IDNA either although curl does, by virtue of
    linking against libidn2. Upgrading from libidn1 to libidn2 in order
    to get proper IDNA 2008 support was the fix for curl's CVE-2016-8625.
    
    libidn2 is not an option (incompatible license) but ICU has an IDNA API
    and we already use that in one place. For non-ICU builds, we fall back
    to the bundled punycode.js that also supports IDNA 2008.
    
    Fixes: nodejs-private/security#97
    Fixes: #25558
    
    PR-URL: #25679
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Older
You can’t perform that action at this time.