Skip to content
Permalink
Branch: master
Commits on Oct 10, 2019
  1. src: remove unused using declarations in worker.cc

    danbev authored and Trott committed Oct 8, 2019
    This commit removes unused using declarations in
    src/node_worker.cc.
    
    PR-URL: #29883
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Sep 26, 2019
  1. src: fix compiler warning in inspector_profiler.cc

    danbev committed Sep 23, 2019
    Currently, the following compiler warnings is generated:
    
    ../src/inspector_profiler.cc:231:5: warning:
    ignoring return value of function declared with 'warn_unused_result'
    attribute [-Wunused-result]
    profile->Set(context, FIXED_ONE_BYTE_STRING(isolate, "source-map-cache")
    ^~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    This commit adds a .ToChecked() call to avoid the warning.
    
    PR-URL: #29660
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Sep 5, 2019
  1. src: fix ValidateDSAParameters when fips is enabled

    danbev committed Sep 2, 2019
    Currently, the following compilation errors are generated when
    configuring --openssl-is-fips:
    
    ../src/node_crypto.cc: In function ‘bool
    node::crypto::ValidateDSAParameters(EVP_PKEY*)’:
    ../src/node_crypto.cc:4886:55: error: ‘pkey’ was not declared in this
    scope
       if (FIPS_mode() && EVP_PKEY_DSA == EVP_PKEY_base_id(pkey.get())) {
                                                           ^~~~
    ../src/node_crypto.cc:4886:55: note: suggested alternative: ‘key’
       if (FIPS_mode() && EVP_PKEY_DSA == EVP_PKEY_base_id(pkey.get())) {
                                                           ^~~~
                                                           key
    ../src/node_crypto.cc:4898:35: error: expected ‘;’ before ‘}’ token
                (L == 3072 && N == 256)
                                       ^
                                       ;
       }
    
    This commit fixes the errors, and after this compilation is successful.
    
    PR-URL: #29407
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Aug 31, 2019
  1. build: hard code doctool in test-doc target

    danbev authored and Trott committed Aug 30, 2019
    This commit removes the usage of the CI_DOC variable in the test-doc
    recipe and specifies the doctool argument to tools/test.py explicitly.
    
    The motivation for this is that the build is taking longer time and
    this is mostly due to tests being run twice as the CI_DOC
    variable will be empty in most cases (when not using --without-ssl).
    
    This change was introduced with/after Commit
    9039af8 ("build: skip test-ci doc
    targets if no crypto") and while I though it might make sense to change
    the setting of CI_DOC I not sure about the implications that might have
    to our CI environment. It currently looks like this:
    
    ifeq ($(node_use_openssl), false)
            CI_DOC := doctool
    else
            CI_DOC =
    endif
    
    Which is setting CI_DOC to doctool if there is no crypto support which
    not available. But perhaps this should be be the other way around,
    changing the order or updating condition to be true.
    
    PR-URL: #29375
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Aug 23, 2019
  1. src: remove unused using declarations

    danbev authored and Trott committed Aug 20, 2019
    This commit removes unused using declarations in
    src/node_contextify.cc.
    
    PR-URL: #29222
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  2. build: move tooltest to before jstest target

    danbev committed Aug 19, 2019
    This commit moves the tooltest target to come before the jstest target
    to make the console output consistent with it was before I introduced
    the tooltest target.
    
    Currently the output looks like this which is might give the impression
    that only one test was run:
    /Applications/Xcode.app/Contents/Developer/usr/bin/make -s tooltest
    .
    ----------------------------------------------------------------------
    Ran 1 test in 0.000s
    
    Compared to the usual:
    [03:58|% 100|+ 2739|-   0]: Done
    
    PR-URL: #29220
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Aug 16, 2019
  1. build: add a testclean target

    danbev authored and Trott committed Aug 12, 2019
    This commit adds a target named testclean to allow for cleaning the
    temporary files generated during a test run without having to use the
    clean target.
    
    PR-URL: #29094
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Aug 14, 2019
  1. test: skip test-fs-access if root

    danbev authored and Trott committed Aug 12, 2019
    Currently, if this test is run as the root user the following
    failure will occur:
    
    === release test-fs-access ===
    Path: parallel/test-fs-access
    (node:46733) internal/test/binding: These APIs are for internal testing
    only. Do not use them.
    Can't clean tmpdir: /root/node/test/.tmp.522
    Files blocking: [ 'read_only_file', 'read_write_file' ]
    
    /root/node/test/common/tmpdir.js:136
        throw e;
        ^
    
    Error: EACCES: permission denied, rmdir '/root/node/test/.tmp.522'
        at Object.rmdirSync (fs.js:693:3)
        at rmdirSync (/root/node/test/common/tmpdir.js:72:8)
        at rimrafSync (/root/node/test/common/tmpdir.js:41:7)
        at process.onexit (/root/node/test/common/tmpdir.js:121:5)
        at process.emit (events.js:214:15) {
      errno: -13,
      syscall: 'rmdir',
      code: 'EACCES',
      path: '/root/node/test/.tmp.522'
    }
    Command: ./node --expose-internals test/parallel/test-fs-access.js
    
    This commit adds a root user check and skips this test if running as the
    user root.
    
    PR-URL: #29092
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Commits on Aug 12, 2019
  1. tools: allow single JS file for --link-module

    danbev committed Jun 27, 2019
    The description for the --link-module configuration option is as
    follows:
    $ ./configure --help | grep -A 5 'link-module'
      --link-module=LINKED_MODULE
                          Path to a JS file to be bundled in the binary as a
                          builtin. This module will be referenced by path
                          without extension; e.g. /root/x/y.js will be
                          referenced via require('root/x/y'). Can be used
                          multiple times
    
    This lead me to think that it was possible to specify a file like this:
    $ ./configure --link-module=something.js
    $ NODE_DEBUG=mkcodecache make -j8
    
    This will lead to a compilation error as an entry in the source_ map in
    node_javascript.cc will end up having an empty string as its key:
    source_.emplace("", UnionBytes{_raw, 105});
    
    This will then be used by CodeCacheBuilder when it iterates over the
    module ids, which will lead to the following compilation errors:
    
    /node/out/Release/obj/gen/node_code_cache.cc:12:23: warning:
    ISO C++17 does not allow a decomposition group to be
    empty [-Wempty-decomposition]
    static const uint8_t [] = {
                          ^
    /node/out/Release/obj/gen/node_code_cache.cc:12:22: warning:
    decomposition declarations are a C++17 extension [-Wc++17-extensions]
    static const uint8_t [] = {
                         ^~
    /node/out/Release/obj/gen/node_code_cache.cc:12:1: error:
    decomposition declaration cannot be declared 'static'
    static const uint8_t [] = {
    ^~~~~~
    /node/out/Release/obj/gen/node_code_cache.cc:12:22: error:
    decomposition declaration cannot be declared with type 'const uint8_t'
    (aka 'const unsigned char'); declared type must be 'auto' or
    reference to 'auto'
    static const uint8_t [] = {
                         ^
    /node/out/Release/obj/gen/node_code_cache.cc:12:22: error:
    excess elements in scalar initializer
    static const uint8_t [] = {
                         ^
    /node/out/Release/obj/gen/node_code_cache.cc:660:7: error:
    expected expression
          ,
          ^
    /node/out/Release/obj/gen/node_code_cache.cc:661:24: error:
    no matching function for call to 'arraysize'
          static_cast<int>(arraysize()), policy
                           ^~~~~~~~~
    ../src/util.h:667:18: note: candidate function template not viable:
    requires 1 argument, but 0 were provided
    constexpr size_t arraysize(const T (&)[N]) {
                     ^
    2 warnings and 5 errors generated.
    
    This commit suggests that passing a single file be allowed by modifying
    tools/js2c.py.
    
    PR-URL: #28443
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Jul 16, 2019
  1. test: update hasFipsCrypto in test/common/README

    danbev authored and Trott committed Jul 5, 2019
    PR-URL: #28507
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  2. test: use openssl_is_fips instead of hasFipsCrypto

    danbev authored and Trott committed Jul 2, 2019
    Currently, when dynamically linking against a FIPS enabled OpenSSL
    library test-process-env-allowed-flags-are-documented will fail with
    the following error:
    assert.js:89
    throw new AssertionError(obj);
    ^
    
    AssertionError [ERR_ASSERTION]:
    The following options are not documented as allowed in NODE_OPTIONS in
    /root/node/doc/api/cli.md: --enable-fips --force-fips
    at Object.<anonymous>
    (/test/parallel/test-process-env-allowed-flags-are-documented.js:82:8)
    at Module._compile (internal/modules/cjs/loader.js:779:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:790:10)
    at Module.load (internal/modules/cjs/loader.js:642:32)
    at Function.Module._load (internal/modules/cjs/loader.js:555:12)
    at Function.Module.runMain (internal/modules/cjs/loader.js:842:10)
    at internal/main/run_main_module.js:17:11 {
    generatedMessage: false,
    code: 'ERR_ASSERTION',
    actual: 2,
    expected: 0,
    operator: 'strictEqual'
    }
    
    This commit updates the test to use
    process.config.variables.openssl_is_fips instead of common.hasFipsCrypto
    as hasFipsCrypto only returns true if the OpenSSL library that is
    shipped with node was configured with FIPS enabled.
    
    PR-URL: #28507
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Jul 5, 2019
  1. src: remove unused using declarations in src/api

    danbev committed Jul 1, 2019
    PR-URL: #28506
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  2. test: create home for test-npm-install

    danbev committed Jul 2, 2019
    This test currently fails if run as root:
    npm ERR! makeDirectory homeless?
    npm WARN install-dir No description
    npm WARN install-dir No repository field.
    npm WARN install-dir No license field.
    
    npm ERR! path /root/node/test/.tmp.0/npm-sandbox/home
    npm ERR! code ENOENT
    npm ERR! errno -2
    npm ERR! syscall stat
    npm ERR! enoent ENOENT:
    no such file or directory,
      stat '/root/node/test/.tmp.0/npm-sandbox/home'
    npm ERR! enoent This is related to npm not being able to find a file.
    npm ERR! enoent
    
    assert.js:89
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: npm install got error code 254
        at handleExit (/root/node/test/parallel/test-npm-install.js:60:10)
        at /root/node/test/common/index.js:371:15
        at ChildProcess.exithandler (child_process.js:304:5)
        at ChildProcess.emit (events.js:203:13)
        at maybeClose (internal/child_process.js:1028:16)
        at Process.ChildProcess._handle.onexit
          (internal/child_process.js:283:5) {
           generatedMessage: false,
           code: 'ERR_ASSERTION',
           actual: 254,
           expected: 0,
           operator: 'strictEqual'
        }
    
    The home directory will be created as expected by npm in the npmSandbox
    when run as non-root, but when run as root this directory has to exist.
    
    This commit creates the home directory to allow the test to pass also
    when run as the root user.
    
    Refs:https://github.com/npm/cli/blob/
    31718e72cb5a03cee7127fc36843e4b55c868d93/
    lib/utils/correct-mkdir.js#L82-L105
    
    PR-URL: #28510
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Commits on Jul 4, 2019
  1. build: remove --code-cache-path help option

    danbev committed Jun 27, 2019
    This commit removes the now obsolete option.
    
    PR-URL: #28446
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Jun 28, 2019
  1. tools: remove unused using declarations

    danbev committed Jun 25, 2019
    PR-URL: #28422
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  2. tools: remove out-of-date code-cache-path comment

    danbev committed Jun 25, 2019
    This commit removes the comment in cache_builder.cc regarding the usage
    of --code-cache-path with configure.
    
    Commit 14df42f ("build: run
    `mkcodecache` as an action") deprecated this option and it is always
    set to yes (unless cross compiling).
    
    PR-URL: #28419
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  3. tools: fix typo in js2c.py

    danbev committed Jun 25, 2019
    PR-URL: #28417
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Jun 26, 2019
  1. tools: fix typo in cache_builder.cc

    danbev committed Jun 25, 2019
    PR-URL: #28418
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Jun 24, 2019
  1. test: use regex for OpenSSL function name

    danbev committed Jun 19, 2019
    This commit modifies test-crypt-scrypt.js to use a regular expression
    for the function name in the error message, similar to what is done for
    the error code.
    
    The motivation for this change comes from a case where we (Red Hat)
    patch OpenSSL and the memory limit checking is done in a different
    function, meaning that the function name from which this error
    originates differs from that when linking to the OpenSSL version shipped
    with Node.js.
    
    PR-URL: #28289
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  2. crypto: move _impl call out of handleError funct

    danbev committed Jun 20, 2019
    This commit moves the _impl function call out of the handleError
    function, which now only takes in an object as its parameter.
    
    PR-URL: #28318
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  3. crypto: move _pbkdf2 call out of handleError funct

    danbev committed Jun 20, 2019
    This commit moves the _pbkdf2 function call out of the handleError
    function, which now only takes in an error and a digest object as
    its parameters.
    
    PR-URL: #28318
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  4. crypto: move _randomBytes call out of handleError funct

    danbev committed Jun 20, 2019
    This commit moves the _randomBytes function call out of the handleError
    function, which now it takes in an error and a buf object as its
    parameters.
    
    PR-URL: #28318
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
  5. crypto: move _scrypt call out of handleError funct

    danbev committed Jun 20, 2019
    This commit moves the _scrypt function call out of the handleError
    function, which now only takes in an error object as its parameter.
    
    The motivation for this is to hopefully improve readability as it was
    not clear to me the first time I stepped through the code where the
    actual call to _scrypt was.
    
    PR-URL: #28318
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jun 19, 2019
  1. src: silence compiler warning node_process_methods

    danbev authored and addaleax committed Jun 17, 2019
    Currently, the following compiler warning is generated by clang:
    ../src/node_process_methods.cc:71:3:
    warning: indirection of non-volatile null pointer will be deleted,
    not trap [-Wnull-dereference]
      *static_cast<volatile void**>(nullptr) = nullptr;
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/node_process_methods.cc:71:3: note:
    consider using __builtin_trap() or qualifying pointer with 'volatile'
    1 warning generated.
    
    This commit adds the volatile qualifier to avoid this warning.
    
    PR-URL: #28261
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Jun 17, 2019
  1. tls: remove unnecessary set of DEFAULT_MAX_VERSION

    danbev committed Jun 10, 2019
    This commit removes what looks like an unnecessary setting of
    exports.DEFAULT_MAX_VALUE.
    
    PR-URL: #28147
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
  2. build: guard test-doc recipe with node_use_openssl

    danbev committed Jun 13, 2019
    Currently, when configuring --without-ssl the test-doc target fails with
    the following error:
    /node/test/common/index.js:707
    const crashOnUnhandledRejection = (err) => { throw err; };
                                                 ^
    
    Error [ERR_NO_CRYPTO]:
    Node.js is not compiled with OpenSSL crypto support
        at Object.assertCrypto (internal/util.js:97:11)
        at https.js:26:26
        at NativeModule.compile (internal/bootstrap/loaders.js:300:5)
        ...
        at /node/tools/doc/versions.js:7:19
        at new Promise (<anonymous>)
        at getUrl (/node/tools/doc/versions.js:6:10)
    Command: out/Release/node /node/test/doctool/test-doctool-html.js
    [00:02|% 100|+   3|-   1]: Done
    make: *** [test-doc] Error 1
    
    This commit guards the test-doc recipe to not run if node was
    configured without crypto support.
    
    PR-URL: #28199
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Jun 16, 2019
  1. src: fix compiler warning in node_worker.cc

    danbev authored and ZYSzys committed Jun 13, 2019
    Currently, when configuring --without-ssl the following compiler warning
    is generated:
    ../src/node_worker.cc:192:10:
    warning: unused variable 'inspector_started' [-Wunused-variable]
        bool inspector_started = false;
             ^
    1 warning generated.
    
    This commit adds a macro guard to the variable to avoid the warning.
    
    PR-URL: #28198
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Jun 13, 2019
  1. tls: rename validateKeyCert in _tls_common.js

    danbev authored and Trott committed Jun 7, 2019
    This commit renames validateKeyCert to validateKeyCertArg to avoid
    confusing this with something that would validate the actual key or
    certificate.
    
    PR-URL: #28116
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Jun 12, 2019
  1. doc: add tls-min/max options to NODE_OPTIONS

    danbev authored and Trott committed Jun 10, 2019
    This commit add the --tls-min and --tls-max command line options to the
    list of allowed options for the NODE_OPTIONS environment variable.
    
    PR-URL: #28146
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Commits on Jun 10, 2019
  1. crypto: add debug info client emit secureConnect

    danbev committed Jun 5, 2019
    Currently, when debugging a TLS connection there might be multiple debug
    statements 'client emit secureConnect' for the 'secureConnect` event
    when using NODE_DEBUG='tls'. While it is possible to step through this
    with a debugger that is not always the fastest/easiest to do if
    debugging remote code.
    
    This commit adds some additional information to the debug statements to
    make it easier to distinguish where the debug statements are coming
    from.
    
    PR-URL: #28067
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Apr 29, 2019
  1. test: skip fs-copyfile-respect-permission if root

    danbev committed Apr 24, 2019
    Currently, if this test is run as the root user the following
    failure will occur:
    
    === release test-fs-copyfile-respect-permissions ===
    Path: parallel/test-fs-copyfile-respect-permissions
    assert.js:89
      throw new AssertionError(obj);
      ^
    AssertionError [ERR_ASSERTION]: Missing expected exception (check).
        at Object.<anonymous>
          (/node/test/parallel/test-fs-copyfile-respect-permissions.js:38:10)
        at Module._compile (internal/modules/cjs/loader.js:759:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
        at Module.load (internal/modules/cjs/loader.js:628:32)
        at Function.Module._load (internal/modules/cjs/loader.js:555:12)
        at Function.Module.runMain (internal/modules/cjs/loader.js:826:10)
        at internal/main/run_main_module.js:17:11
    Command:
    out/Release/node test/parallel/test-fs-copyfile-respect-permissions.js
    [05:41|% 100|+ 2620|-   1]: Done
    
    This commit adds a root user check and skips this test if running as the
    user root.
    
    PR-URL: #27378
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Commits on Mar 27, 2019
  1. Revert "console: use consolePropAttributes for k-bind properties in c…

    danbev committed Mar 27, 2019
    …onstructor"
    
    This reverts commit ed5e69d.
    
    PR-URL: #26943
    Refs: #26850 (comment)
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
Commits on Mar 25, 2019
  1. src: guard exit label when inspector disabled

    danbev committed Mar 20, 2019
    Currently, when configured --without-inspector the following warning
    will be generated:
    ../src/node.cc:859:1: warning: unused label 'exit' [-Wunused-label]
    exit:
    
    This commit adds a guard to exclude the label when there is no
    inspector support.
    
    PR-URL: #26801
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Commits on Mar 12, 2019
  1. test: fix compiler warning in test_string.c

    danbev committed Mar 9, 2019
    Currently, the following compiler warnings is generated:
    
    ../test_string.c:235:50: warning:
    incompatible pointer types passing 'char [1]' to parameter of type
    'const char16_t *' (aka 'const unsigned short *')
    [-Wincompatible-pointer-types]
    NAPI_CALL(env, napi_create_string_utf16(env,
        "", ((size_t)INT_MAX) + 1, &output));
        ^~
    ../../common.h:50:23: note: expanded from macro 'NAPI_CALL'
      NAPI_CALL_BASE(env, the_call, NULL)
                          ^~~~~~~~
    ../../common.h:42:10: note: expanded from macro 'NAPI_CALL_BASE'
        if ((the_call) != napi_ok) {                               \
             ^~~~~~~~
    /node/src/js_native_api.h:80:66: note:
    passing argument to parameter 'str' here const char16_t* str,
                                                             ^
    1 warning generated.
    
    This commit adds a cast to silence this warning.
    
    PR-URL: #26539
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Feb 25, 2019
  1. src: use smart pointer in UDPWrap::OnSend

    danbev committed Feb 21, 2019
    PR-URL: #26233
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Older
You can’t perform that action at this time.