Permalink
Commits on Oct 3, 2018
  1. doc: clarify assigning issues to the TSC

    fhinkel authored and Trott committed Sep 7, 2018
    PR-URL: #22759
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Commits on Jan 18, 2018
  1. doc: V8 branch used in 8.x not active anymore

    fhinkel authored and addaleax committed Jan 15, 2018
    Add 8.x to the LTS versions that use a V8 branch that is
    not active anymore.
    
    PR-URL: #18155
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Dec 8, 2017
  1. doc: add "Hello world" example for N-API

    fhinkel authored and apapirovski committed Dec 2, 2017
    Our Addons documentation has a "Hello world" example that
    outlines all steps to build it. Adding the sources for this
    "Hello world" example for N-API.
    
    PR-URL: #17425
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Dec 6, 2017
  1. deps: cherry-pick 37a3a15c3 from V8 upstream

    fhinkel authored and targos committed Oct 18, 2017
    Original commit message:
      [api] Intercept DefineProperty after Descriptor query
    
      Analog to other interceptors, intercept the DefineProperty
      call only after obtaining the property descriptor.
    
      This behavior allows us to mirror calls on a sandboxed object
      as it is needed in Node. See for example
      #13265
    
      Bug:
      Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3
      Reviewed-on: https://chromium-review.googlesource.com/725295
      Reviewed-by: Andreas Haas <ahaas@chromium.org>
      Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48683}
    
    PR-URL: #16294
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
Commits on Dec 5, 2017
  1. doc: update example in module registration

    fhinkel committed Dec 4, 2017
    Update return type of `Init` function in documentation to match
    `napi_addon_register_func` signature. Return type used to be
    `void`, now it is `napi_value`.
    
    PR-URL: #17424
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Dec 3, 2017
  1. doc: introduce categories to Cpp style guide

    fhinkel committed Nov 17, 2017
    Ref: #17052 (comment)
    
    PR-URL: #17095
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Nov 19, 2017
  1. src: use unique_ptr for http2_state

    fhinkel authored and addaleax committed Nov 16, 2017
    PR-URL: #17078
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  2. src: use unique_ptr for scheduled delayed tasks

    fhinkel committed Nov 12, 2017
    Use std::unique_ptr for delayed tasks in the scheduled
    delayed tasks vector. This makes it clear that the vector
    has ownership of the delayed tasks and is responsible for
    deleting them.
    
    Use a custom deleter for the pointers because libuv
    needs to close the handle and then delete the data. Provide
    the handle when creating the pointer instead of invoking the
    special delete action everytime an element is removed from the vector.
    
    PR-URL: #17083
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
  3. src: use std::unique_ptr in base-object-inl.h

    fhinkel committed Nov 16, 2017
    Drive-by fix: delete superflouos nullptr in ptr.reset().
    
    PR-URL: #17079
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Commits on Nov 17, 2017
  1. doc: mention smart pointers in Cpp style guide

    fhinkel committed Nov 15, 2017
    Add rule for smart pointers, i.e., std::unique_ptr and std::shared_ptr,
    to the Cpp style guide. Mostly copied from the Google style guide.
    
    PR-URL: #17055
    Ref: #16970
    Ref: #16974
    Ref: #17000
    Ref: #17012
    Ref: #17020
    Ref: #17030
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  2. src: use smart pointer instead of new and delete

    fhinkel committed Nov 12, 2017
    Use an std::unique_ptr for variables that are deleted
    right after creation.
    
    Since the destructor of InspectorTimer is private
    but needed by the unique_ptr, define deleter_type as friend.
    
    PR-URL: #17020
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Commits on Nov 16, 2017
  1. src: make ownership of stdio_pipes explicit

    fhinkel committed Nov 14, 2017
    Use smart pointers instead of raw pointers for StdioPipes.
    Also, use a smart pointer for the array holding them.
    
    PR-URL: #17030
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  2. doc: add Table of Contents to Cpp style guide

    fhinkel committed Nov 15, 2017
    The Cpp style guide is growing. IMHO, a Table of Contents makes
    it easier to navigate.
    
    PR-URL: #17052
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
  3. src: use unique pointer for tracing_agent

    fhinkel committed Nov 12, 2017
    Use std::unique_ptr instead of raw pointers for the
    tracing_agent_ in node.cc. This makes ownership clearer and we
    don't risk a memory leak.
    
    PR-URL: #17012
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Commits on Nov 15, 2017
  1. src: use unique_ptr for requests in crypto

    fhinkel committed Nov 13, 2017
    Instead of raw pointerns, use std::unique_ptr for PBKDF2Request and
    RandomBytesRequest. This makes ownership more clear.
    
    PR-URL: #17000
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Nov 14, 2017
  1. deps: cherry-pick 3c8195d from V8 upstream

    fhinkel committed Nov 9, 2017
    Original commit message:
    
      [map] Fix map constructor to correctly throw.
    
      We need to throw before rethrowing, otherwise the exception does
      not trigger a debugger event and is not reported if uncaught.
    
      R=gsathya@chromium.org, jgruber@chromium.org
    
      Bug: v8:7047
      Change-Id: I7ce0253883a21d6059e4e0ed0fc56dc55a0dcba6
      Reviewed-on: https://chromium-review.googlesource.com/758372
      Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49237}
    
    PR-URL: #16897
    Fixes: #16856
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
  2. src: turn inspector raw pointer into unique_ptr

    fhinkel committed Nov 12, 2017
    Use a unique pointer to make ownership clear.
    
    PR-URL: #16974
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
  3. src: use unique_ptr in platform implementation

    fhinkel committed Nov 12, 2017
    Replace raw pointers in task queues with std::unique_ptr. This
    makes ownership obvious.
    
    PR-URL: #16970
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Commits on Nov 12, 2017
  1. src: explain implementation of vm module

    fhinkel authored and jasnell committed Nov 9, 2017
    The vm module uses interceptors on the object template. This is not
    straight forward and a comment in the source will help the next
    person working on this.
    
    PR-URL: #16962
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Nov 10, 2017
  1. deps: cherry-pick cc55747 from V8 upstream

    fhinkel committed Nov 8, 2017
    This fixes the flaky message/console test on our CI.
    
    Original commit message:
      [test/message] Allow numbers to have more than one leading digit.
    
      The {NUMBER} regexp only allowed one, leading to occasional test
      failures such as:
      https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/17156
    
      Bug:
      Change-Id: I25a08b80640d9af19ba70c61c846163685f1cb82
      Reviewed-on: https://chromium-review.googlesource.com/753322
      Reviewed-by: Franziska Hinkelmann <franzih@chromium.org>
      Commit-Queue: Georg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49109}
    
    PR-URL: #16890
    Ref: nodejs/build#936
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Nov 9, 2017
  1. doc: improve documentation for the vm module

    fhinkel committed Nov 7, 2017
    Add an intro section and example for the vm module.
    
    PR-URL: #16867
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Oct 27, 2017
  1. src: fix vm module for strict mode

    fhinkel committed Oct 25, 2017
    This patch fixes the problem with variables that
    are declared only on the sandbox but not on the
    global proxy.
    
    PR-URL: #16487
    Fixes: #12300
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
Commits on Oct 25, 2017
  1. test: fix test for inherited properties on vm

    fhinkel committed Oct 23, 2017
    The known issue is fixed with
    #16293.
    
    The text needs to call `Object.hasOwnProperty(this)`
    instead of `this.hasOwnProperty()`, otherwise `this` is
    from the wrong context is used.
    
    Add a second test case taken verbatim from issue
    #5350
    
    PR-URL: #16411
    Fixes: #5350
    Ref: #16293
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Oct 23, 2017
  1. src: use new V8 API in vm module

    fhinkel committed Oct 17, 2017
    Remove the CopyProperties() hack in the vm module, i.e., Contextify.
    Use different V8 API methods, that allow interception of
    DefineProperty() and do not flatten accessor descriptors to
    property descriptors.
    
    Move many known issues to test cases. Factor out the last test in
    test-vm-context.js for
    #10223
    into its own file, test-vm-strict-assign.js.
    
    Part of this CL is taken from a stalled PR by
    https://github.com/AnnaMag
    #13265
    
    This PR requires a backport of
    https://chromium.googlesource.com/v8/v8/+/37a3a15c3e52e2146e45f41c427f24414e4d7f6f
    
    PR-URL: #16293
    Fixes: #2734
    Fixes: #10223
    Fixes: #11803
    Fixes: #11902
    Ref: #6283
    Ref: #15114
    Ref: #13265
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
  2. deps: cherry-pick 37a3a15c3 from V8 upstream

    fhinkel committed Oct 18, 2017
    Original commit message:
      [api] Intercept DefineProperty after Descriptor query
    
      Analog to other interceptors, intercept the DefineProperty
      call only after obtaining the property descriptor.
    
      This behavior allows us to mirror calls on a sandboxed object
      as it is needed in Node. See for example
      #13265
    
      Bug:
      Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3
      Reviewed-on: https://chromium-review.googlesource.com/725295
      Reviewed-by: Andreas Haas <ahaas@chromium.org>
      Commit-Queue: Franziska Hinkelmann <franzih@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48683}
    
    PR-URL: #16294
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
Commits on Oct 12, 2017
  1. doc: add pronoun for fhinkel

    fhinkel authored and Trott committed Oct 7, 2017
    PR-URL: #16069
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
Commits on Aug 23, 2017
  1. test: add known issue for vm module

    fhinkel authored and jasnell committed Aug 7, 2017
    GlobalPropertySetterCallback() does not check the
    property on the sandbox. It wrongly throws an error
    instead of updating `x`.
    
    PR-URL: #14661
    Ref: #12300
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Commits on Jul 30, 2017
  1. src: replace deprecated ForceSet() method

    fhinkel authored and addaleax committed Jul 24, 2017
    ForceSet() is marked to be deprecated. Replacing
    it with DefineOwnProperty().
    
    PR-URL: #14450
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Commits on Mar 28, 2017
  1. test: fix misleading comment

    fhinkel committed Mar 26, 2017
    The comment is outdated, function declarations have
    nothing to do with defineProperties.
    
    PR-URL: #12048
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 25, 2017
  1. deps: cherry-pick 0ba513f05 from V8 upstream

    fhinkel authored and targos committed Mar 6, 2017
    Original commit message:
      [api] Fix DescriptorInterceptor with access check.
    
      The DescriptorInterceptor should intercept all
      Object.getOwnPropertyDescriptor calls. This CL fixes
      the interceptor's behavior if the iterator state is
      ACCESS_CHECK.
    
      BUG=
    
      Review-Url: https://codereview.chromium.org/2707263002
      Cr-Commit-Position: refs/heads/master@{#43417}
    
    PR-URL: #11712
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 19, 2017
  1. deps: cherry-pick 09de996 from V8 upstream

    fhinkel committed Mar 17, 2017
    Original commit message:
      [debugger] fix switch block source positions.
    
      The switch statement itself is part of the switch block.
      However, the source position of the statement is outside of
      the block. This leads to confusion for the debugger, if the
      switch block pushes a block context: the current context is
      a block context, but the scope analysis based on the current
      source position tells the debugger that we should be outside
      the scope, so we should have the function context.
    
      R=marja@chromium.org
      BUG=v8:6085
      Review-Url: https://codereview.chromium.org/2744213003
      Cr-Commit-Position: refs/heads/master@{#43744}
      Committed: https://chromium.googlesource.com/v8/v8/+/09de9969ccb9bc3bbd667788afad665b309d02f5
    
    Fixes: #11746
    PR-URL: #11905
    Fixes: #11746
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Commits on Mar 14, 2017
  1. doc: update to current V8 versions

    fhinkel committed Mar 10, 2017
    Update the documentation to the correct V8 versions
    in the guide *Maintaining V8 in Node.js*.
    
    PR-URL: #11787
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Mar 9, 2017
  1. deps: cherry-pick 0ba513f05 from V8 upstream

    fhinkel committed Mar 6, 2017
    Original commit message:
      [api] Fix DescriptorInterceptor with access check.
    
      The DescriptorInterceptor should intercept all
      Object.getOwnPropertyDescriptor calls. This CL fixes
      the interceptor's behavior if the iterator state is
      ACCESS_CHECK.
    
      BUG=
    
      Review-Url: https://codereview.chromium.org/2707263002
      Cr-Commit-Position: refs/heads/master@{#43417}
    
    PR-URL: #11712
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
Commits on Feb 14, 2017
  1. doc: update link to V8 Embedder's guide

    fhinkel committed Feb 13, 2017
    V8 moved the Embeder's guide to GitHub.
    
    PR-URL: #11336
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Commits on Feb 11, 2017
  1. test: add vm module edge cases

    fhinkel authored and jasnell committed Feb 9, 2017
    Add two, admittedly contrived, examples that test
    edge cases of the vm module.
    They demonstrate that the if statements `if (maybe_rv.IsEmpty())` and
    `if (maybe_prop_attr.IsNothing())` in the GetterCallback
    and the QueryCallback are observable.
    
    Both GetterCallback and QueryCallback
    explicitly check the global_proxy() if a property is
    not found on the sandbox. In these tests, the explicit check
    inside the callback yields different results than deferring the
    check until after the callback. The check is deferred, if the
    callbacks do not intercept, i.e., if args.GetReturnValue().Set() is
    not called.
    
    PR-URL: #11265
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>